Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-ecs/lib/base/task-definition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ export class TaskDefinition extends TaskDefinitionBase {
assumedBy: new iam.ServicePrincipal('ecs-tasks.amazonaws.com'),
});

if (props.inferenceAccelerators) {
if (props.inferenceAccelerators && props.inferenceAccelerators.length > 0) {
props.inferenceAccelerators.forEach(ia => this.addInferenceAccelerator(ia));
}

Expand Down
28 changes: 20 additions & 8 deletions packages/aws-cdk-lib/aws-ecs/lib/ec2/ec2-task-definition.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,26 @@ export class Ec2TaskDefinition extends TaskDefinition implements IEc2TaskDefinit
* Constructs a new instance of the Ec2TaskDefinition class.
*/
constructor(scope: Construct, id: string, props: Ec2TaskDefinitionProps = {}) {
super(scope, id, {
...props,
compatibility: Compatibility.EC2,
placementConstraints: props.placementConstraints,
ipcMode: props.ipcMode,
pidMode: props.pidMode,
inferenceAccelerators: props.inferenceAccelerators,
});
// don't pass @deprecated inferenceAccelerators if not needed as this renders console warnings
if (props.inferenceAccelerators && props.inferenceAccelerators.length > 0) {
super(scope, id, {
...props,
compatibility: Compatibility.EC2,
placementConstraints: props.placementConstraints,
ipcMode: props.ipcMode,
pidMode: props.pidMode,
inferenceAccelerators: props.inferenceAccelerators,
});
} else {
super(scope, id, {
...props,
compatibility: Compatibility.EC2,
placementConstraints: props.placementConstraints,
ipcMode: props.ipcMode,
pidMode: props.pidMode,
});
}

// Enhanced CDK Analytics Telemetry
addConstructMetadata(this, props);

Expand Down
Loading