Skip to content

fix(ec2): don't use inferenceAccellerators in the constructors if not needed #34618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 23, 2025
Merged

fix(ec2): don't use inferenceAccellerators in the constructors if not needed #34618

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5ddbaed
fix for inferenceAccelerators
rantoniuk Jun 3, 2025
d4406eb
don't pass inferenceAccelerators if not defined
rantoniuk Jun 18, 2025
9e3dc12
Comment why this condition is needed
rantoniuk Jun 20, 2025
acf4c42
lint fix
rantoniuk Jun 20, 2025
3cfc9f0
review: revert some changes
rantoniuk Jun 20, 2025
4a546fb
Merge branch 'main' into 33505-inferenceAccelerators
mergify[bot] Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions packages/aws-cdk-lib/aws-ecs/lib/ec2/ec2-task-definition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,26 @@ export class Ec2TaskDefinition extends TaskDefinition implements IEc2TaskDefinit
* Constructs a new instance of the Ec2TaskDefinition class.
*/
constructor(scope: Construct, id: string, props: Ec2TaskDefinitionProps = {}) {
super(scope, id, {
...props,
compatibility: Compatibility.EC2,
placementConstraints: props.placementConstraints,
ipcMode: props.ipcMode,
pidMode: props.pidMode,
inferenceAccelerators: props.inferenceAccelerators,
});
// don't pass @deprecated inferenceAccelerators if not needed as this renders console warnings
if (props.inferenceAccelerators) {
super(scope, id, {
...props,
compatibility: Compatibility.EC2,
placementConstraints: props.placementConstraints,
ipcMode: props.ipcMode,
pidMode: props.pidMode,
inferenceAccelerators: props.inferenceAccelerators,
});
} else {
super(scope, id, {
...props,
compatibility: Compatibility.EC2,
placementConstraints: props.placementConstraints,
ipcMode: props.ipcMode,
pidMode: props.pidMode,
});
}

// Enhanced CDK Analytics Telemetry
addConstructMetadata(this, props);

Expand Down
Loading