Skip to content

Conversation

@moelasmar
Copy link
Contributor

Reverts #33887

@moelasmar moelasmar requested a review from a team as a code owner May 6, 2025 19:09
@github-actions github-actions bot added the p2 label May 6, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team May 6, 2025 19:09
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 6, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@moelasmar moelasmar changed the title Revert "feat: property injection for 122 constructs" revert "feat: property injection for 122 constructs" May 6, 2025
@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.99%. Comparing base (1e722ad) to head (0412fe5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #34370      +/-   ##
==========================================
- Coverage   84.10%   83.99%   -0.12%     
==========================================
  Files         124      121       -3     
  Lines        7009     6934      -75     
  Branches     1176     1164      -12     
==========================================
- Hits         5895     5824      -71     
+ Misses       1003      999       -4     
  Partials      111      111              
Flag Coverage Δ
suite.unit 83.99% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 83.99% <ø> (-0.12%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gracelu0 gracelu0 changed the title revert "feat: property injection for 122 constructs" revert: "feat: property injection for 122 constructs" May 6, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 6, 2025 20:25

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ CodeCov is indicating a drop in code coverage

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0412fe5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@gracelu0 gracelu0 merged commit 2594f3c into main May 6, 2025
21 of 24 checks passed
@gracelu0 gracelu0 deleted the revert-33887-prop-injectors branch May 6, 2025 22:12
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants