From 4d7894eff90670aaabe821060b68e110170e1303 Mon Sep 17 00:00:00 2001 From: ykethan Date: Wed, 23 Apr 2025 21:40:44 -0400 Subject: [PATCH 1/4] update issue templates --- .github/ISSUE_TEMPLATE/bug-report.yml | 13 +++++++------ .github/ISSUE_TEMPLATE/feature-request.yml | 12 ++++++++++-- 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 530d831d8980c..1185894d20909 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -84,19 +84,20 @@ body: required: false - type: input - id: cdk-version + id: cdk-lib-version attributes: - label: CDK CLI Version - description: Output of `cdk version` + label: AWS CDK Library version (aws-cdk-lib) + description: Run `npm ls aws-cdk-lib` at the root of your CDK project validations: required: true - type: input - id: framework-version + id: cdk-cli-version attributes: - label: Framework Version + label: AWS CDK CLI version + description: Run `npx cdk --version` to get the version of the AWS CDK CLI validations: - required: false + required: true - type: input id: node-version diff --git a/.github/ISSUE_TEMPLATE/feature-request.yml b/.github/ISSUE_TEMPLATE/feature-request.yml index 3747a5aad65aa..23483c1ffac66 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.yml +++ b/.github/ISSUE_TEMPLATE/feature-request.yml @@ -46,9 +46,17 @@ body: - label: This feature might incur a breaking change required: false - type: input - id: sdk-version + id: cdk-lib-version attributes: - label: CDK version used + label: AWS CDK Library version (aws-cdk-lib) + description: Run `npm ls aws-cdk-lib` at the root of your CDK project + validations: + required: true + - type: input + id: cdk-cli-version + attributes: + label: AWS CDK CLI version + description: Run `npx cdk --version` to get the version of the AWS CDK CLI validations: required: true - type: input From fe0e003827db90c7524db58a478cf5d10270625f Mon Sep 17 00:00:00 2001 From: ykethan Date: Wed, 23 Apr 2025 21:45:44 -0400 Subject: [PATCH 2/4] nit --- .github/ISSUE_TEMPLATE/bug-report.yml | 2 +- .github/ISSUE_TEMPLATE/feature-request.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 1185894d20909..921747338b5c9 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -95,7 +95,7 @@ body: id: cdk-cli-version attributes: label: AWS CDK CLI version - description: Run `npx cdk --version` to get the version of the AWS CDK CLI + description: Run `npx cdk --version` to get the version of AWS CDK CLI validations: required: true diff --git a/.github/ISSUE_TEMPLATE/feature-request.yml b/.github/ISSUE_TEMPLATE/feature-request.yml index 23483c1ffac66..9f66627537652 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.yml +++ b/.github/ISSUE_TEMPLATE/feature-request.yml @@ -56,7 +56,7 @@ body: id: cdk-cli-version attributes: label: AWS CDK CLI version - description: Run `npx cdk --version` to get the version of the AWS CDK CLI + description: Run `npx cdk --version` to get the version of AWS CDK CLI validations: required: true - type: input From 6960cb2a8e73bbb09f49325ec233a96a9fe47bdf Mon Sep 17 00:00:00 2001 From: ykethan Date: Wed, 23 Apr 2025 21:57:24 -0400 Subject: [PATCH 3/4] minor nits --- .github/ISSUE_TEMPLATE/bug-report.yml | 4 ++-- .github/ISSUE_TEMPLATE/feature-request.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 921747338b5c9..838987941358e 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -31,7 +31,7 @@ body: - type: input id: working-version attributes: - label: Last Known Working CDK Version + label: Last Known Working CDK Library Version description: Specify the last known CDK version where this code was functioning as expected (if applicable). validations: required: false @@ -95,7 +95,7 @@ body: id: cdk-cli-version attributes: label: AWS CDK CLI version - description: Run `npx cdk --version` to get the version of AWS CDK CLI + description: Run `cdk --version` for global version or `npx cdk --version` at the root of your CDK project validations: required: true diff --git a/.github/ISSUE_TEMPLATE/feature-request.yml b/.github/ISSUE_TEMPLATE/feature-request.yml index 9f66627537652..c93d244024c94 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.yml +++ b/.github/ISSUE_TEMPLATE/feature-request.yml @@ -56,7 +56,7 @@ body: id: cdk-cli-version attributes: label: AWS CDK CLI version - description: Run `npx cdk --version` to get the version of AWS CDK CLI + description: Run `cdk --version` for global version or `npx cdk --version` at the root of your CDK project validations: required: true - type: input From aa16a8626fc7ec4f721c474ebc8f8df0e6004524 Mon Sep 17 00:00:00 2001 From: ykethan Date: Wed, 23 Apr 2025 22:00:28 -0400 Subject: [PATCH 4/4] minor nits --- .github/ISSUE_TEMPLATE/bug-report.yml | 4 ++-- .github/ISSUE_TEMPLATE/feature-request.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 838987941358e..650bf0f4fba73 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -32,7 +32,7 @@ body: id: working-version attributes: label: Last Known Working CDK Library Version - description: Specify the last known CDK version where this code was functioning as expected (if applicable). + description: Specify the last known CDK Library version where this code was functioning as expected (if applicable). validations: required: false - type: textarea @@ -95,7 +95,7 @@ body: id: cdk-cli-version attributes: label: AWS CDK CLI version - description: Run `cdk --version` for global version or `npx cdk --version` at the root of your CDK project + description: Run `cdk --version` for global installation or `npx cdk --version` at the root of your CDK project validations: required: true diff --git a/.github/ISSUE_TEMPLATE/feature-request.yml b/.github/ISSUE_TEMPLATE/feature-request.yml index c93d244024c94..7218e2e158059 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.yml +++ b/.github/ISSUE_TEMPLATE/feature-request.yml @@ -56,7 +56,7 @@ body: id: cdk-cli-version attributes: label: AWS CDK CLI version - description: Run `cdk --version` for global version or `npx cdk --version` at the root of your CDK project + description: Run `cdk --version` for global installation or `npx cdk --version` at the root of your CDK project validations: required: true - type: input