fix(pipelines): can't have the same asset display name 3 times

[rix0rrr]

When introducing friendly asset names in #33844, we made a mistake in calculating unique action names for distinct assets with the same display name.

As a result, the same asset could be added to the pipeline twice, but not thrice.

The simplest fix would have been to move the increment before the reassignment of name:

            // Before
            if (nameCount > 0) {
              name += `${nameCount + 1}`;
            }
            namesCtrs.set(name, nameCount + 1);

            // After
            namesCtrs.set(name, nameCount + 1);
            if (nameCount > 0) {
              name += `${nameCount + 1}`;
            }

But it occurred to me that that would still lead to problems if there were actions with display names that would conflict with the numbered names in that way (e.g., ['asdf', 'asdf', 'asdf2'], leading to action names ['asdf', 'asdf2', 'asdf2']).

So what we do instead is linear probing: increment a counter for every name and pick the first name that is unused.

Also in this PR: Stages can't have a name of only one character. Fix that.

Closes #34004.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (009680d) to head (5170341).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #34017   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112           

Flag	Coverage Δ
suite.unit	83.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	83.98% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 5170341
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.