-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(scheduler-alpha-and-scheduler-targets-alpha): remove alpha modules #33951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33951 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 120 120
Lines 6955 6955
Branches 1173 1173
=======================================
Hits 5730 5730
Misses 1120 1120
Partials 105 105
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Leo10Gama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, though I wonder if we need to update some of the integration tests. Seems like the tree.json files in the snapshots for each are noted as using the alpha module's resources:

The tests will still pass, since I think it only checks the template anyways, but we should probably update the snapshots with the new values if we can
Leo10Gama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, the changes are fine as is and the only issue is the tree.json files for the snapshots. Will approve and let this in to catch the release, and the snapshot updates will be in a separate PR. Thanks!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
The aws-scheduler-alpha and aws-scheduler-targets-alpha modules have now been stabilized so we can delete the alpha modules. Also update any remaining references to these deprecated alpha modules.
Description of changes
Removed
aws-scheduler-alphaandaws-scheduler-targets-alphamodules from@aws-cdkpackageDescription of how you validated changes
Ran
yarn installandnpx lerna run buildsuccessfully. Verified all integ tests are passing.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license