Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 24, 2025

Reverts #33092

This test hadn't gone through the testing pipeline successfully yet.

@rix0rrr rix0rrr requested a review from a team as a code owner January 24, 2025 13:55
@aws-cdk-automation aws-cdk-automation requested a review from a team January 24, 2025 13:55
@github-actions github-actions bot added the p2 label Jan 24, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 24, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added the pr-linter/exempt-codecov The PR linter will not require codecov checks to pass label Jan 24, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 24, 2025 14:01

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.57%. Comparing base (5377586) to head (7e8f0b9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33139   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files         227      227           
  Lines       13793    13793           
  Branches     2419     2419           
=======================================
  Hits        11251    11251           
  Misses       2270     2270           
  Partials      272      272           
Flag Coverage Δ
suite.unit 81.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.99% <ø> (ø)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@rix0rrr rix0rrr merged commit b1dfdd2 into main Jan 24, 2025
40 of 42 checks passed
@rix0rrr rix0rrr deleted the revert-33092-huijbers/isolated-proxy-test branch January 24, 2025 14:09
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7e8f0b9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-codecov The PR linter will not require codecov checks to pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants