chore: don't add the same Aspect more than once #32880
Conversation
There is no observable behavior from adding the same Aspect more than once at the same priority, but we are adding multiple `AspectApplication`s for it (and then only executing once). Make the proptest results a bit easier to read by not allowing this in the first place.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32880 +/- ##
==========================================
- Coverage 81.38% 81.38% -0.01%
==========================================
Files 222 222
Lines 13750 13698 -52
Branches 2423 2413 -10
==========================================
- Hits 11191 11148 -43
+ Misses 2279 2271 -8
+ Partials 280 279 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
3 participants
There is no observable behavior from adding the same Aspect more than once at the same priority, but we are adding multiple
AspectApplications for it (and then only executing once).Make the proptest results a bit easier to read by not allowing this in the first place.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license