fix(cli): spawning node fails when node path contains spaces

[decompil3d]

When spawning a Node.js child process, if the node executable is under a path that contains spaces or other characters that need to be escaped, the spawn fails. This is due to how Node.js handles child_process.spawn when shell is set to true.

The fix is to (1) revert to using an array to pass in the command and arguments (initially changed in #17176) and (2) quote the command. The change for (1) is a refactor so that we may allow an array OR a string to be passed into exec.

I've verified that this change fixes the reported issue by modifying the bundled index.js locally. It's not clear how to best test this within exec.test.js since the Node.js process path is progmatically extracted from the app context. I'm happy to adjust the PR if the maintainers have a suggestion here.

Closes aws/aws-cdk-cli#636.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: da4a996
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[TheRealAmazonKendra]

Thank you for your contribution! Nothing wrong with this change from first glance, but we do already have a solution for this problem. We have files called os.ts that do this so I'd prefer to reuse one of those than rewrite this work again.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/24001/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.