Skip to content

docs(appmesh): note that virtual nodes allow at most one listener at this time #13550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 4 commits into from
Mar 18, 2021
Merged

docs(appmesh): note that virtual nodes allow at most one listener at this time #13550

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dff8e19
fix(appmesh): virtual node should allow at most one listener
misterjoshua Mar 11, 2021
4c13b40
improve the error wording
misterjoshua Mar 11, 2021
4043864
revert code changes, add documentation
misterjoshua Mar 12, 2021
9ad0fce
Merge branch 'master' into fix-virtual-node-listener
mergify[bot] Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,13 @@ export class VirtualNode extends VirtualNodeBase {

/**
* Utility method to add an inbound listener for this VirtualNode
*
* Note: At this time, Virtual Nodes support at most one listener. Adding
* more than one will result in a failure to deploy the CloudFormation stack.
* However, the App Mesh team has plans to add support for multiple listeners
* on Virtual Nodes and Virtual Routers.
*
* @see https://github.com/aws/aws-app-mesh-roadmap/issues/120
*/
public addListener(listener: VirtualNodeListener) {
this.listeners.push(listener.bind(this));
Expand Down