From 239ab55b9a02b7fba6e043c2b279cc66f1833bfb Mon Sep 17 00:00:00 2001 From: Elad Ben-Israel Date: Thu, 4 Mar 2021 14:54:16 +0200 Subject: [PATCH 1/2] chore: fix auto-approve workflow I believe the reason our auto-approve workflow does not work is because it was triggered when the pull request was _created_ and before the `pr/auto-approve` label was applied to it. This adds `types: [ labeled ]` so the workflow is triggered when a PR is labeled. The condition remains the same. --- .github/workflows/auto-approve.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/auto-approve.yml b/.github/workflows/auto-approve.yml index cf2ed7e21ca69..fe37c7a968661 100644 --- a/.github/workflows/auto-approve.yml +++ b/.github/workflows/auto-approve.yml @@ -1,7 +1,9 @@ # Approve PRs with "pr/auto-approve". mergify takes care of the actual merge. name: auto-approve -on: pull_request +on: + pull_request: + types: [ labeled ] jobs: auto-approve: From 6f88534e515a2255ba26f07b3a56e3eb857132e9 Mon Sep 17 00:00:00 2001 From: Elad Ben-Israel Date: Thu, 4 Mar 2021 15:21:11 +0200 Subject: [PATCH 2/2] Update .github/workflows/auto-approve.yml Co-authored-by: Niranjan Jayakar --- .github/workflows/auto-approve.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/auto-approve.yml b/.github/workflows/auto-approve.yml index fe37c7a968661..c289f5381995c 100644 --- a/.github/workflows/auto-approve.yml +++ b/.github/workflows/auto-approve.yml @@ -3,7 +3,7 @@ name: auto-approve on: pull_request: - types: [ labeled ] + types: [ labeled, unlabeled, opened, synchronize, reopened, ready_for_review, review_requested ] jobs: auto-approve: