chore: fix auto-approve workflow #13392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the reason our auto-approve workflow does not work is because it was triggered when the pull request was _created_ and before the `pr/auto-approve` label was applied to it. This adds `types: [ labeled ]` so the workflow is triggered when a PR is labeled. The condition remains the same.
|
|
nija-at
approved these changes
Mar 4, 2021
Co-authored-by: Niranjan Jayakar <[email protected]>
Contributor
Author
|
@nija-at thanks, done. |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
cornerwings
pushed a commit
to cornerwings/aws-cdk
that referenced
this pull request
Mar 8, 2021
I believe the reason our auto-approve workflow does not work is because it was triggered when the pull request was _created_ and before the `pr/auto-approve` label was applied to it. This adds `types: [ labeled ]` so the workflow is triggered when a PR is labeled. The condition remains the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the reason our auto-approve workflow does not work is because it was triggered when the pull request was created and before the
pr/auto-approvelabel was applied to it.This adds
types: [ labeled ]so the workflow is triggered when a PR is labeled. The condition remains the same.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license