From 2bc32d3a63e62883690cdbea59cb4cdf05280249 Mon Sep 17 00:00:00 2001 From: Niranjan Jayakar Date: Mon, 8 Feb 2021 11:14:59 +0000 Subject: [PATCH] chore: fix github actions name and dependencies Github actions for v2 are failing because of a dependency definition on an incorrect name. See [failures]. Further, the dependency is incorrect. The 'auto-approve' job needs to run on PRs besides forward merges. Fix Github action names and remove the incorrect dependency. [failures]: https://github.com/aws/aws-cdk/actions/runs/547681911 --- .github/workflows/v2-pull-request.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/v2-pull-request.yml b/.github/workflows/v2-pull-request.yml index d82955767b01a..c4118d3298a00 100644 --- a/.github/workflows/v2-pull-request.yml +++ b/.github/workflows/v2-pull-request.yml @@ -15,8 +15,7 @@ on: jobs: # Run yarn pkglint on merge forward PRs and commit the results - checkout: - name: pkglint + pkglint: if: contains(github.event.pull_request.labels.*.name, 'pr/forward-merge') runs-on: ubuntu-latest steps: @@ -36,9 +35,7 @@ jobs: # Approve automated PRs # Only approve! mergify takes care of the actual merge. - approve: - name: auto-approve - needs: pkglint + auto-approve: if: > github.event.pull_request.user.login == 'aws-cdk-automation' && contains(github.event.pull_request.labels.*.name, 'pr/auto-approve')