chore: remove strong-named key references and signing for .NET #12632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benefits of strong-name signing assemblies are marginal at best, and it turns out we actually weren't strong-name signing our assemblies anyway, making all of this extra infrastructure unnecessary. This removes the strong-name key (SNK) prebuild script, updates the buildspec to remove the reference to it, and removes the linter rule that enforced the strong-named assembly properties. Prior to removal, the rule was reversed and used to update the package.json files. This change will be accompanied by a change to our pipeline definition to remove the references on that side.
|
|
RomainMuller
approved these changes
Jan 21, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mohanrajendran
pushed a commit
to mohanrajendran/aws-cdk
that referenced
this pull request
Jan 24, 2021
…2632) The benefits of strong-name signing assemblies are marginal at best, and it turns out we actually weren't strong-name signing our assemblies anyway, making all of this extra infrastructure unnecessary. This removes the strong-name key (SNK) prebuild script, updates the buildspec to remove the reference to it, and removes the linter rule that enforced the strong-named assembly properties. Prior to removal, the rule was reversed and used to update the package.json files. This change will be accompanied by a change to our pipeline definition to remove the references on that side. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benefits of strong-name signing assemblies are marginal at best, and it
turns out we actually weren't strong-name signing our assemblies anyway, making
all of this extra infrastructure unnecessary.
This removes the strong-name key (SNK) prebuild script, updates the buildspec
to remove the reference to it, and removes the linter rule that enforced the
strong-named assembly properties. Prior to removal, the rule was reversed and
used to update the package.json files.
This change will be accompanied by a change to our pipeline definition to
remove the references on that side.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license