-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(efs): EFS fails to create when using a VPC with multiple subnets per availability zone #12097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
3e5f1d1
Fix #10170
daisuke-yoshimoto d2edf2d
Fix build error
daisuke-yoshimoto 16b189d
Merge branch 'master' into fix-10170
daisuke-yoshimoto 289b59f
Fix test case
daisuke-yoshimoto 94d010f
Fix test cases
daisuke-yoshimoto caf9377
Merge branch 'master' into fix-10170
daisuke-yoshimoto 69e859e
Merge branch 'master' into fix-10170
daisuke-yoshimoto 5c12b8b
Merge branch 'master' into fix-10170
daisuke-yoshimoto fac9dce
Merge branch 'master' into fix-10170
daisuke-yoshimoto 0db1223
Merge branch 'master' into fix-10170
daisuke-yoshimoto 4a8873a
Merge branch 'master' into fix-10170
daisuke-yoshimoto d972fe4
Merge branch 'master' into fix-10170
daisuke-yoshimoto 7d6ca57
Merge branch 'master' into fix-10170
daisuke-yoshimoto 84c841b
Merge branch 'master' into fix-10170
daisuke-yoshimoto 90ab7af
Merge branch 'master' into fix-10170
daisuke-yoshimoto bcdf3f6
Fix to review indication
daisuke-yoshimoto 1e80154
Fix
daisuke-yoshimoto 00c6661
Fix
daisuke-yoshimoto 7efb690
Merge branch 'master' into fix-10170
daisuke-yoshimoto 8a55c79
Merge branch 'master' into fix-10170
daisuke-yoshimoto 03e463c
Merge branch 'master' into fix-10170
daisuke-yoshimoto e9d7f00
Add unit test
daisuke-yoshimoto d8607d1
Fix unit test
daisuke-yoshimoto b8075ba
Merge branch 'master' into fix-10170
daisuke-yoshimoto 9d16980
Fix unit test
daisuke-yoshimoto 90f5d39
Merge branch 'fix-10170' of https://github.com/daisuke-yoshimoto/aws-…
daisuke-yoshimoto 05f4986
Merge branch 'master' into fix-10170
daisuke-yoshimoto 80e92dd
Simplify test
iliapolo 2b6fcc1
Merge branch 'master' into fix-10170
iliapolo f732eca
Removed unused import
iliapolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add a test for this. should there be a warning or error to indicate that mounts targets are not created