Skip to content
Merged
Changes from 3 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
3e5f1d1
Fix #10170
daisuke-yoshimoto Dec 15, 2020
d2edf2d
Fix build error
daisuke-yoshimoto Dec 15, 2020
16b189d
Merge branch 'master' into fix-10170
daisuke-yoshimoto Dec 17, 2020
289b59f
Fix test case
daisuke-yoshimoto Dec 17, 2020
94d010f
Fix test cases
daisuke-yoshimoto Dec 17, 2020
caf9377
Merge branch 'master' into fix-10170
daisuke-yoshimoto Dec 17, 2020
69e859e
Merge branch 'master' into fix-10170
daisuke-yoshimoto Dec 17, 2020
5c12b8b
Merge branch 'master' into fix-10170
daisuke-yoshimoto Dec 17, 2020
fac9dce
Merge branch 'master' into fix-10170
daisuke-yoshimoto Dec 21, 2020
0db1223
Merge branch 'master' into fix-10170
daisuke-yoshimoto Dec 22, 2020
4a8873a
Merge branch 'master' into fix-10170
daisuke-yoshimoto Dec 22, 2020
d972fe4
Merge branch 'master' into fix-10170
daisuke-yoshimoto Dec 22, 2020
7d6ca57
Merge branch 'master' into fix-10170
daisuke-yoshimoto Dec 23, 2020
84c841b
Merge branch 'master' into fix-10170
daisuke-yoshimoto Jan 4, 2021
90ab7af
Merge branch 'master' into fix-10170
daisuke-yoshimoto Jan 6, 2021
bcdf3f6
Fix to review indication
daisuke-yoshimoto Jan 9, 2021
1e80154
Fix
daisuke-yoshimoto Jan 9, 2021
00c6661
Fix
daisuke-yoshimoto Jan 9, 2021
7efb690
Merge branch 'master' into fix-10170
daisuke-yoshimoto Jan 9, 2021
8a55c79
Merge branch 'master' into fix-10170
daisuke-yoshimoto Jan 18, 2021
03e463c
Merge branch 'master' into fix-10170
daisuke-yoshimoto Jan 28, 2021
e9d7f00
Add unit test
daisuke-yoshimoto Jan 28, 2021
d8607d1
Fix unit test
daisuke-yoshimoto Jan 29, 2021
b8075ba
Merge branch 'master' into fix-10170
daisuke-yoshimoto Jan 29, 2021
9d16980
Fix unit test
daisuke-yoshimoto Jan 30, 2021
90f5d39
Merge branch 'fix-10170' of https://github.com/daisuke-yoshimoto/aws-…
daisuke-yoshimoto Jan 30, 2021
05f4986
Merge branch 'master' into fix-10170
daisuke-yoshimoto Jan 30, 2021
80e92dd
Simplify test
iliapolo Jan 31, 2021
2b6fcc1
Merge branch 'master' into fix-10170
iliapolo Jan 31, 2021
f732eca
Removed unused import
iliapolo Jan 31, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/@aws-cdk/aws-efs/lib/efs-file-system.ts
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,13 @@ export class FileSystem extends Resource implements IFileSystem {
defaultPort: ec2.Port.tcp(FileSystem.DEFAULT_PORT),
});

this.mountTargetsAvailable = [];
if (props.vpcSubnets === undefined) return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a test for this. should there be a warning or error to indicate that mounts targets are not created


const subnets = props.vpc.selectSubnets(props.vpcSubnets);

// We now have to create the mount target for each of the mentioned subnet
let mountTargetCount = 0;
this.mountTargetsAvailable = [];
subnets.subnetIds.forEach((subnetId: string) => {
const mountTarget = new CfnMountTarget(this,
'EfsMountTarget' + (++mountTargetCount),
Expand Down