feat: intro "Names.uniqueId()" instead of the deprecated "node.uniqueId"

[eladb]

The property node.uniqueId is used throughout our codebase to generate unique names. We are planning to deprecate this API in constructs 10.x (and CDK 2.0) in favor of a node.addr (see aws/constructs#314).

In most cases, these generated names cannot be changed because they will incur breaking changes to deployments. So we have to continue to use the "legacy" unique ID in those cases (new cases should use addr).

To that end, we introduce a utility Legacy.uniqueId() which uses the legacy algorithm and the code base was migrated to use it instead of node.uniqueId which will go away soon.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[rix0rrr]

I don't really like the name Legacy, because I don't agree new code should exclusively use addr. addr has no semblance of human readability anymore.

Let's categorize where we use uniqueId:

• As a path component -- fine, I can live with a hash here.
• As a generated physical ID in case CFN doesn't generate one for us, or we need a stable one -- losing human readability would be less than ideal.

[eladb]

As a generated physical ID in case CFN doesn't generate one for us, or we need a stable one -- losing human readability would be less than ideal.

Ideally I'd want those generated physical IDs to use addr under the hood and not the old unique ID algorithm, but I can see the use case for an official way to produce IDs with a human readable portion based on the construct path. Ideally, this should be done by creating a domain-compatible human readable portion and postfixing addr.

I am also okay with being pragmatic here and keeping the current uniqueId algorithm in AWS CDK.

I'll revise to:

import { Names } from 'core';

Names.uniqueId(c);
Names.nodeUniqueId(c.node);

Sounds okay?

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 7191193
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).