-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(sns): enable passing PolicyDocument to TopicPolicy #10559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1aacd1c
Merge pull request #1 from aws/master
ap00rv d2ddd86
fix(sns): enable creating instance of TopicPolicy
ap00rv 5212845
Merge branch 'master' into sns-policy-fix
MrArnoldPalmer c50aa37
Merge branch 'master' into sns-policy-fix
MrArnoldPalmer ca65180
add breaking change exclusion
MrArnoldPalmer c490390
make policy document optional
MrArnoldPalmer 1cef14f
remove passed default in addToResourcePolicy
MrArnoldPalmer 47f98b1
Merge branch 'master' into sns-policy-fix
MrArnoldPalmer 357cc5e
add to readme
MrArnoldPalmer a91330b
Merge branch 'sns-policy-fix' of github.com:ap00rv/aws-cdk into sns-p…
MrArnoldPalmer 21779c1
lint fix
MrArnoldPalmer de2c666
Merge branch 'master' into sns-policy-fix
ap00rv 331dcaf
Merge branch 'master' into sns-policy-fix
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.