Skip to content

Conversation

@krokoko
Copy link
Contributor

@krokoko krokoko commented Nov 21, 2025

Issue # (if applicable)

  • Remove namespace from gateway perms causing the release of an empty submodule
  • Add validation logic to ensure no error when unresolved token for duration in runtime
  • Move files under lib and remove the /agentcore folder

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK p2 labels Nov 21, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team November 21, 2025 15:41
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@krokoko krokoko changed the title fix(agentcore): perms and validation chore(agentcore): perms and validation, structure Nov 21, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 21, 2025 16:09

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 21, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@alvazjor alvazjor changed the title chore(agentcore): perms and validation, structure fix(bedrock-agentcore-alpha): empty submodule accidentally exposed and runtime validation fix Nov 21, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #36148 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

  • #changes-requested-reviews-by=0
  • check-success=build
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default-squash]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • check-success=build
      • any of: [🛡 GitHub branch protection]
        • check-neutral = build
        • check-skipped = build
        • check-success = build.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@alvazjor alvazjor added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Nov 21, 2025
@alvazjor
Copy link
Contributor

@Mergifyio refresh

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 21, 2025 17:15

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2025

refresh

✅ Pull request refreshed

@alvazjor
Copy link
Contributor

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 72d3e6f into aws:main Nov 21, 2025
32 of 33 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants