Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 10, 2025

Issue

53 submodules of aws-cdk-lib used the wrong .NET package name.

Example:

# ❌  wrong
Amazon.CDK.aws_bedrockagentcore

# ✅ correct
Amazon.CDK.AWS.BedrockAgentCore

❌ wrong
image

✅ correct
image

Full list of affected submodules:

aws-aiops
aws-applicationsignals
aws-apptest
aws-arcregionswitch
aws-arczonalshift
aws-b2bi
aws-backupgateway
aws-bcmdataexports
aws-bedrock
aws-bedrockagentcore
aws-billing
aws-cleanrooms
aws-cleanroomsml
aws-codeconnections
aws-connectcampaignsv2
aws-datazone
aws-deadline
aws-dsql
aws-entityresolution
aws-evs
aws-gameliftstreams
aws-healthimaging
aws-invoicing
aws-launchwizard
aws-mediapackagev2
aws-mpa
aws-neptunegraph
aws-notifications
aws-notificationscontacts
aws-observabilityadmin
aws-odb
aws-osis
aws-paymentcryptography
aws-pcaconnectorad
aws-pcaconnectorscep
aws-pcs
aws-proton
aws-qbusiness
aws-rbin
aws-route53profiles
aws-rtbfabric
aws-s3express
aws-s3tables
aws-s3vectors
aws-securitylake
aws-shield
aws-smsvoice
aws-ssmguiconnect
aws-ssmquicksetup
aws-verifiedpermissions
aws-workspacesinstances
aws-workspacesthinclient
aws-workspacesweb

Reason for this change

The name of submodules is determined by a .jsiirc.json‎ inside the submodule directory. If not present, the export name is appended to the name of the parent module. However for most jsii languages this convention is not great: JavaScript export names don't translate well into other ecosystems.

For aws-cdk-lib we therefore have added .jsiirc.json‎ files into each submodule. For new services, this file is generated when the service is first added. Due to a bug, this generated file was incorrectly adding the key package to the dotnet target configuration. It should have been namespace instead.

Since this was a mistake, we are fixing this now. It means that the package names for the listed 53 submodules are changing for .NET users.

Description of changes

Update the package names of the listed 53 submodules to use the correct configuration.

Adjusted the order of targets in other .jsiirc.json files to be the same as generated ones.

Describe any new or updated permissions being added

n/a

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 10, 2025 18:17
@github-actions github-actions bot added the p2 label Nov 10, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 10, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mrgrain mrgrain changed the title fix: multiple submodules use an incorrect namespace for .Net fix(cdk-lib): multiple submodules use an incorrect namespace for .NET Nov 10, 2025
@mrgrain mrgrain added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Nov 10, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 10, 2025 19:04

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mrgrain mrgrain marked this pull request as ready for review November 11, 2025 09:12
@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Nov 11, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #36002 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

  • -label~=(blocked|do-not-merge|no-squash|two-approvers|priority-pr)
  • check-success=build
  • check-success=validate-pr
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default-squash]
      • -label~=(blocked|do-not-merge|no-squash|priority-pr)
      • check-success=build
      • check-success=validate-pr
      • any of: [🛡 GitHub branch protection]
        • check-neutral = validate-pr
        • check-skipped = validate-pr
        • check-success = validate-pr
      • any of: [🛡 GitHub branch protection]
        • check-neutral = build
        • check-skipped = build
        • check-success = build.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mrgrain mrgrain force-pushed the mrgrain/fix/submodules-use-incorrect-dotnet-namespace branch from 5dc10f7 to 3bfb562 Compare November 11, 2025 10:00
@mrgrain mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label Nov 11, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e48e584 into main Nov 11, 2025
18 of 19 checks passed
@mergify mergify bot deleted the mrgrain/fix/submodules-use-incorrect-dotnet-namespace branch November 11, 2025 11:16
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants