-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(cdk-lib): multiple submodules use an incorrect namespace for .NET #36002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk-lib): multiple submodules use an incorrect namespace for .NET #36002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: Pull request #36002 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
5dc10f7 to
3bfb562
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue
53 submodules of
aws-cdk-libused the wrong .NET package name.Example:
❌ wrong

✅ correct

Full list of affected submodules:
Reason for this change
The name of submodules is determined by a
.jsiirc.jsoninside the submodule directory. If not present, the export name is appended to the name of the parent module. However for most jsii languages this convention is not great: JavaScript export names don't translate well into other ecosystems.For
aws-cdk-libwe therefore have added.jsiirc.jsonfiles into each submodule. For new services, this file is generated when the service is first added. Due to a bug, this generated file was incorrectly adding the keypackageto thedotnettarget configuration. It should have beennamespaceinstead.Since this was a mistake, we are fixing this now. It means that the package names for the listed 53 submodules are changing for .NET users.
Description of changes
Update the package names of the listed 53 submodules to use the correct configuration.
Adjusted the order of targets in other
.jsiirc.jsonfiles to be the same as generated ones.Describe any new or updated permissions being added
n/a
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license