-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(stepfunctions): allow multiline jsonata strings #35985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stepfunctions): allow multiline jsonata strings #35985
Conversation
… string is wrapped in the Step Functions JSONata expression tags. The "s" flag allows the dot to match across newlines, enabling the use of well-formatted complex expressions. Include unit tests for both helper functions in jsonata.ts. Reuse isValidJsonataExpression where the same regex expression was used in condition and task-utils.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
983431b to
747dafd
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue #35912
Closes #35912.
Reason for this change
The inability to use multiline JSONata expressions in certain places, for example:
Description of changes
String.startsWithandString.endsWith, but opted for the minimal change to preserve the existing regex which is also likely more performant.jsonata.ts.isValidJsonataExpressionwhere the same regex expression was used incondition.tsandtask-utils.ts.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license