fix(ecs): remove empty CfnClusterCapacityProviderAssociations resource

[aemada-aws]

Issue # (if applicable)

Closes #35699
Related to: #35742

Reason for this change

CfnClusterCapacityProviderAssociations is not needed when using only managed instances as a capacity provider, but it was being created anyway with empty values. It is needed if default capacity providers are set, or the capacity provider is not of the managed instances type.

Description of changes

Removed the clusterScopedCapacityProviderNames check when creating CfnClusterCapacityProviderAssociations.

Destructive changes: CfnClusterCapacityProviderAssociations will be deleted if user does not provide default capacity providers or default fargate and uses only ManagedInstancesCapacityProvider.

Describe any new or updated permissions being added

None

Description of how you validated changes

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[Abogical]

I believe a unit test checking if the CfnClusterCapacityProviderAssociations resource is removed needs to be added.

[aemada-aws]

I believe a unit test checking if the CfnClusterCapacityProviderAssociations resource is removed needs to be added.

added one

[Abogical]

Thanks!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

[Abogical]

@Mergifyio update

[mergify]

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/analytics-metadata-updater.yml without workflows permission

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[Abogical]

@Mergifyio requeue

[mergify]

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.