Skip to content

Conversation

@Abogical
Copy link
Member

Issue # (if applicable)

Related to #35729.

Reason for this change

A PassRole policy is created whenever a cloudwatch destination is setup for a VPC flow destination. This is not needed as indicated from the VPC flow docs.

Description of changes

Removed policy.

Describe any new or updated permissions being added

PassRole policy is removed.

Description of how you validated changes

Unit tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@Abogical Abogical added the pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots. label Oct 16, 2025
@Abogical Abogical had a problem deploying to deployment-integ-test October 16, 2025 14:47 — with GitHub Actions Failure
@aws-cdk-automation aws-cdk-automation requested a review from a team October 16, 2025 14:47
@github-actions github-actions bot added p2 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Oct 16, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 16, 2025
@mergify mergify bot had a problem deploying to deployment-integ-test October 16, 2025 14:54 Failure
@mergify mergify bot had a problem deploying to deployment-integ-test October 17, 2025 09:37 Error
@Abogical
Copy link
Member Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2025

rebase

✅ Branch has been successfully rebased

@Abogical Abogical force-pushed the vpc-flow-remove-pass-role branch from 8a9b750 to ac73f2e Compare October 17, 2025 09:39
@Abogical Abogical had a problem deploying to deployment-integ-test October 17, 2025 09:39 — with GitHub Actions Failure
@Abogical Abogical added p1 and removed p2 labels Oct 22, 2025
@Abogical Abogical had a problem deploying to deployment-integ-test October 22, 2025 09:26 — with GitHub Actions Error
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 22, 2025
@Abogical
Copy link
Member Author

@Mergifyio rebase

@Abogical Abogical force-pushed the vpc-flow-remove-pass-role branch from ac73f2e to 7aec1a2 Compare October 23, 2025 08:21
@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2025

rebase

✅ Branch has been successfully rebased

@Abogical Abogical temporarily deployed to deployment-integ-test October 23, 2025 08:21 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation added the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Oct 23, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 27, 2025
@Abogical
Copy link
Member Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot temporarily deployed to deployment-integ-test October 28, 2025 14:38 Inactive
@mergify mergify bot merged commit c4b80df into main Oct 28, 2025
21 of 22 checks passed
@mergify mergify bot deleted the vpc-flow-remove-pass-role branch October 28, 2025 15:29
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

admired-contributor [Pilot] contributed between 13-24 PRs to the CDK contribution/core This is a PR that came from AWS. p1 pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants