-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(ec2): remove PassRole policy emitted by cloudwatch vpc flow destination #35762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Mergifyio rebase |
Contributor
✅ Branch has been successfully rebased |
8a9b750 to
ac73f2e
Compare
Member
Author
|
@Mergifyio rebase |
ac73f2e to
7aec1a2
Compare
Contributor
✅ Branch has been successfully rebased |
aemada-aws
approved these changes
Oct 27, 2025
Member
Author
|
@Mergifyio requeue |
Contributor
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
admired-contributor
[Pilot] contributed between 13-24 PRs to the CDK
contribution/core
This is a PR that came from AWS.
p1
pr/needs-further-review
PR requires additional review from our team specialists due to the scope or complexity of changes.
pr/needs-integration-tests-deployment
Requires the PR to deploy the integration test snapshots.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Related to #35729.
Reason for this change
A PassRole policy is created whenever a cloudwatch destination is setup for a VPC flow destination. This is not needed as indicated from the VPC flow docs.
Description of changes
Removed policy.
Describe any new or updated permissions being added
PassRole policy is removed.
Description of how you validated changes
Unit tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license