-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(apigateway): add binaryMediaTypes property to SpecRestApi
#35502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apigateway): add binaryMediaTypes property to SpecRestApi
#35502
Conversation
1754d12 to
f37a525
Compare
2c0ed78 to
18974e5
Compare
kumsmrit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. I have added a minor review comment.
| * The list of binary media mime-types that are supported by the RestApi | ||
| * resource, such as "image/png" or "application/octet-stream" | ||
| * | ||
| * @default - RestApi supports only UTF-8-encoded text payloads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: RestApi -> SpecRestApi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i fixed comment, thanks for review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated
You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue #35498
Reason for this change
The
SpecRestApiconstruct was missing thebinaryMediaTypesproperty that is available in the regularRestApiconstruct.Description of changes
binaryMediaTypesproperty toSpecRestApiPropsinterface**: This property accepts an array of strings representing binary media types (e.g.,['image/png', 'application/pdf'])SpecRestApiconstructor**: Modified to pass thebinaryMediaTypesproperty to the underlyingCfnRestApiresourcebinaryMediaTypeswithSpecRestApiDescribe any new or updated permissions being added
N/A
Description of how you validated changes
binaryMediaTypesproperty is correctly passed to CloudFormationbinaryMediaTypesconfigurationChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license