-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(ecr-assets): TarballImageAsset respects CDK_DOCKER environment variable
#35344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
TarballImageAsset respects CDK_DOCKER environment variable
TarballImageAsset respects CDK_DOCKER environment variableTarballImageAsset respects CDK_DOCKER environment variable
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
6a828e8 to
634213e
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #35336.
Reason for this change
The
TarballImageAssetclass hardcoded thedockercommand in its executable array instead of respecting theCDK_DOCKERenvironment variable. This caused failures when users tried to use alternative container runtimes like Finch, breaking existing workflows that rely onCDK_DOCKERfor container runtime selection.Description of changes
TarballImageAssetto use${process.env.CDK_DOCKER ?? 'docker'}pattern instead of hardcoded 'docker' commandThe fix makes
TarballImageAssetconsistent with other CDK components that already respect theCDK_DOCKERenvironment variable, using the exact same pattern used throughout the CDK codebase.Describe any new or updated permissions being added
N/A - No IAM permissions or resource access changes. This is a build-time bug fix affecting asset preparation only.
Description of how you validated changes
CDK_DOCKER=custom-dockerand verifies the executable array contains the custom command. All existing tests continue to pass (35/35 tests in aws-ecr-assets module).CDK_DOCKER=finchto verify alternative container runtime support works correctly.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license