-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(route53): warn when ttl is provided with alias target in RecordSet #34526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
matboros
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests for your change
When creating a Route53 RecordSet with an alias target, the ttl property is ignored since alias targets don't use TTL values. This change adds a warning annotation to inform users when they provide a ttl value that will be ignored. This improves developer experience by making it clear when a provided configuration option has no effect, helping users avoid confusion and potential misconfigurations.
fff86a9 to
8f60c3c
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
N/A
Reason for this change
When creating a Route53 RecordSet with an alias target, the ttl property is ignored since alias targets don't use TTL values.
Description of changes
This change adds a warning annotation to inform users when they provide a ttl value that will be ignored. This improves developer experience by making it clear when a provided configuration option has no effect, helping users avoid confusion and potential misconfigurations.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Created a resource that triggers the warning as shown below, then linked my PR changes and ran
$ cdk synthChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license