feat(ec2): support for client route enforcement for client VPN endpoint

[badmintoncryer]

Issue # (if applicable)

None

Reason for this change

Cloudformation supports for configuring client route enforcement feature for client VPN endpoint.

Description of changes

• Add enableClientRouteEnforcement prop to ClientVpnEndpointProps

Describe any new or updated permissions being added

None

Description of how you validated changes

Add both unit and integ tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[mazyu36]

Thank you for the contribution.
I've added a nit comment.

[badmintoncryer]

@mazyu36 Thank you for your review! I've reflected your suggestions.

[mazyu36]

LGTM.
But something went wrong...

[mazyu36]

Thanks!

[badmintoncryer]

@mazyu36 Thanks always!

[kumsmrit]

Thank you for your contribution; I have added few comments.

[kumsmrit]

Property name should be enableClientRouteEnforcement.

[kumsmrit]

The AWS Client VPN docs note that Client Route Enforcement only works in full-tunnel mode, and will silently have no effect if split-tunnel is enabled (see: https://docs.aws.amazon.com/vpn/latest/clientvpn-admin/cvpn-working-cre.html). To prevent users from creating such configurations that won't work as expected, we could add a validation check:

if (props.enableClientRouteEnforcement && props.splitTunnel) {
  throw new ValidationError(
    'Client Route Enforcement cannot be enabled when splitTunnel is true',
    this
  );
}

[badmintoncryer]

Thanks! I have not realized this restriction.

[kumsmrit]

For future extensibility, we can consider using an interface approach instead of direct boolean flag:

interface ClientRouteEnforcementOptions {
 readonly enforced: boolean;
}
readonly clientRouteEnforcementOptions?: ClientRouteEnforcementOptions;

This would align with CFN structure (see: aws-properties-ec2-clientvpnendpoint-clientrouteenforcementoptions and would be forward compatible if more properties are added to ClientRouteEnforcementOptions. Moving from a boolean flag to an interface later would be a breaking change.

[badmintoncryer]

Sure. I've updated my implementation to define ClientRouteEnforcemnetOptions.

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 5deb544
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.