Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ec2): implement IPeer to PrefixList to be usable as a connection peer #33617

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(ec2): implement IPeer to PrefixList to be usable as a connection peer #33617

wants to merge 5 commits into from
+994 −22

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Feb 28, 2025

Issue # (if applicable)

Closes #33607.

Reason for this change

When we want to add a security group rule with PrefixList as a connection peer,
we should write redundant prefixList:

const pl = new ec2.PrefixList(this, 'PrefixList', { ... });
instance.connections.allowFrom(ec2.Peer.prefixList(pl.prefixListId), ec2.Port.XXX);

This PR allows us to write DRY:

const pl = new ec2.PrefixList(this, 'PrefixList', { ... });
instance.connections.allowFrom(pl, ec2.Port.XXX);

Description of changes

  • Modify the IPrefixList interface to extend IPeer
  • Implement the required IPeer methods in PrefixListBase

Describe any new or updated permissions being added

Nothing

Description of how you validated changes

Added unit tests and updated an integ test.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 28, 2025 02:02
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Feb 28, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (6c882e0) to head (158f486).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33617   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103
Flag Coverage Δ
suite.unit 82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 28, 2025
@Tietew Tietew mentioned this pull request Feb 28, 2025
Open
1 task
@github-actions github-actions bot mentioned this pull request Mar 1, 2025
Open
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 158f486
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ec2: implement IPeer to PrefixList
2 participants
@Tietew @aws-cdk-automation