Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cx-api): throw CloudAssemblyError instead of untyped Errors #33390

Merged

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Feb 11, 2025

Issue

Relates to #32569

Description of changes

ValidationErrors everywhere

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Existing tests. Exemptions granted as this is a refactor of existing code.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain requested a review from a team as a code owner February 11, 2025 11:20
@github-actions github-actions bot added the p2 label Feb 11, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 11, 2025 11:20
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 11, 2025
@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-codecov The PR linter will not require codecov checks to pass labels Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (d3f3309) to head (899a19a).

❌ Your patch check has failed because the patch coverage (33.33%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #33390      +/-   ##
==========================================
- Coverage   80.92%   80.91%   -0.02%     
==========================================
  Files         236      236              
  Lines       14255    14258       +3     
  Branches     2491     2492       +1     
==========================================
+ Hits        11536    11537       +1     
- Misses       2434     2436       +2     
  Partials      285      285              
Flag Coverage Δ
suite.unit 80.91% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.74% <ø> (ø)
packages/aws-cdk-lib/core 82.18% <33.33%> (-0.03%) ⬇️

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Feb 11, 2025
Copy link
Contributor

@iankhou iankhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description of changes refers to ValidationError, but should probably reference CloudAssemblyError.

Copy link
Contributor

mergify bot commented Feb 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Feb 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 12, 2025
Copy link
Contributor

mergify bot commented Feb 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 899a19a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ae95d95 into main Feb 12, 2025
16 of 20 checks passed
@mergify mergify bot deleted the feature/featcx-api-throw-cloudassemblyerror-instead-of-unt branch February 12, 2025 12:00
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-codecov The PR linter will not require codecov checks to pass pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants