feat(s3-deployment): support securityGroups in BucketDeploymentProps #33233
+150
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
beginning-contributor
aws-cdk-automation
requested changes
Jan 30, 2025
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
drduhe
force-pushed
the
issue/33229
branch
2 times, most recently
from
e9003c1 to
ba8b378
Compare
|
Exemption Request - I don't think this requires a change to integration tests, per other similar PR guidance. There is also no integration tests for this module it seems. |
aws-cdk-automation
added
pr-linter/exemption-requested
packages/aws-cdk-lib/aws-s3-deployment/lib/bucket-deployment.ts
Outdated
Show resolved
Hide resolved
drduhe
force-pushed
the
issue/33229
branch
6 times, most recently
from
8da326c to
a2a7583
Compare
github-actions
bot
added
the
effort/medium
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
closes #33229
Reason for this change
The
BucketDeploymentconstruct in AWS CDK allows deploying assets to S3 buckets, often requiring a Lambda function to perform the deployment. Currently, users can specify a custom VPC viaBucketDeploymentProps, ensuring the deployment happens within a restricted network.However, many organizations require more granular network security control. While specifying a VPC is helpful, allowing custom security groups would enable teams to define specific ingress/egress rules, meeting stricter compliance and security requirements.
Description of changes
BucketDeploymentPropsto include an optionalsecurityGroups?: ec2.ISecurityGroup[]property.BucketDeploymentconstructor to passsecurityGroupsto the Lambda function.securityGroupsoptional.vpc,vpcSubnets, andsecurityGroupsparameters.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added unit tests to the relevant code modules to cover feature usage.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license