Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-ecr-assets): Custom ECR repository, custom name and/or tag #33228

Open
2 tasks
wdolek opened this issue Jan 29, 2025 · 1 comment
Open
2 tasks

(aws-ecr-assets): Custom ECR repository, custom name and/or tag #33228

wdolek opened this issue Jan 29, 2025 · 1 comment
Labels
@aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@wdolek
Copy link

wdolek commented Jan 29, 2025

Describe the feature

Using CDK 2.177.0, it is not possible to declare custom ECR for images built to be used by ECS. Not only that, it's also impossible to tag those images meaningfully.

Allow user:

  • ... publishing to custom ECR without 3rd party library (as it was possible with CDK 1.0)
  • and/or custom name of image and tagging
    (if custom ECR is not possible, at least allow this as workaround)

This is follow up of #12597 and/or #25595 which have been closed without providing any working solution, and discussion #33157.

Use Case

Every image created for any project using same AWS account/region ends up in very same ECR which makes image management impossible. Reasoning why current CDK behavior is not optimal is well described in App Staging Synthesizer article (link below).

Tickets mentioned above failed to deliver any of this or replacement of CDK 1.0 behavior, because:

  • cdklabs/cdk-ecr-deployment doesn't seem to work for all use cases/runtimes/frameworks (see comments of those tickets!)
    • deploying custom lambda to juggle images feels bit complicated (another resource to watch) - pushing directly to dedicated repository seems to be more elegant
    • 3rd party library without support
  • App Staging Synthesizer is not providing required flexibility
    • being alpha even after years and not part of core CDK library
    • imo poorly documented, not many options available, no troubleshooting guide
      (failed to make it work with existing CDK project - can't actually provide better feedback)

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.177.0

Environment details (OS name and version, etc.)

linux, node:20-alpine

@wdolek wdolek added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 29, 2025
@github-actions github-actions bot added the @aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets label Jan 29, 2025
@pahud pahud self-assigned this Jan 30, 2025
@pahud
Copy link
Contributor

pahud commented Jan 30, 2025

Thank you for bringing this up. Yes I agree with you. I am making this a p2 FR. Please help us prioritize with 👍 . Meanwhile, I'll bring this up for the team for visbility.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 30, 2025
@pahud pahud removed their assignment Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants