feat(eks-v2): new eks v2 alpha module #33215
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33215 +/- ##
=======================================
Coverage 80.79% 80.79%
=======================================
Files 232 232
Lines 14106 14106
Branches 2452 2452
=======================================
Hits 11397 11397
Misses 2429 2429
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| }, | ||
| }, | ||
| }); | ||
| app.synth(); |
There was a problem hiding this comment.
nit: don't need app.synth() in integration tests anymore when using the integ test framework (applies to other integ tests in this module)
There was a problem hiding this comment.
Good catch. Will remove them.
| * This function check if the instanceType is GPU instance. | ||
| * @param instanceType The EC2 instance type | ||
| */ | ||
| export function isGpuInstanceType(instanceType: InstanceType): boolean { |
There was a problem hiding this comment.
Just for my understanding why is this moved to private folder?
There was a problem hiding this comment.
It's from the PR: #32715
| readonly bucketName: string; | ||
| readonly timeout?: Duration; | ||
| } | ||
| export class BucketPinger extends Construct { |
There was a problem hiding this comment.
Just for my understanding, how come we no longer need this?
There was a problem hiding this comment.
I'd like to rewrite this part so it will come in a separate PR.
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Rewrite the EKS module using native CFN L1 cluster resource along with other breaking changes.
Description of changes
For this PR:
Describe any new or updated permissions being added
N/A
Description of how you validated changes
unit tests/integration tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license