Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoscaling): cooldown cannot be set with step scaling actions #30150

Merged
merged 5 commits into from
May 12, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented May 10, 2024

Issue # (if applicable)

Closes #29779

Reason for this change

cooldown cannot be set on step scaling and can cause deployment failure in certain regions.

Description of changes

Deprecate the property and ignore the value. Give a warning.

Description of how you validated changes

Unit test added.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 10, 2024 21:42
@github-actions github-actions bot added the p2 label May 10, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 10, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@GavinZZ GavinZZ marked this pull request as ready for review May 10, 2024 22:14
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort labels May 10, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 10, 2024 23:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 11, 2024
Copy link
Contributor

mergify bot commented May 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label May 12, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a3e86ba
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6810762 into main May 12, 2024
15 checks passed
@mergify mergify bot deleted the yuanhaoz/scaling_cooldown_fix branch May 12, 2024 00:38
Copy link
Contributor

mergify bot commented May 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-autoscaling: Step scaling properties expose unsupported cooldown property
3 participants