Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(servicecatalog): ProductStack memoryLimit prop #30105

Merged
merged 5 commits into from
May 15, 2024

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented May 8, 2024

Issue # (if applicable)

Closes #29862

Reason for this change

Exposes BucketDeployment's memoryLimit prop in the ProductStack class. While not an ideal solution, this allows users to handle larger files

Description of changes

  • Added memoryLimit to ProductStackProps and the internal ProductStackSynthesizerProps

Description of how you validated changes

Updated unit and integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 8, 2024 13:34
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels May 8, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@nmussy nmussy changed the title feat(servicecatalog): ProductStack memoryLimit prop feat(servicecatalog): ProductStack memoryLimit prop May 8, 2024
@nmussy nmussy marked this pull request as ready for review May 8, 2024 15:32
@nmussy
Copy link
Contributor Author

nmussy commented May 13, 2024

Exemption request: memoryLimit is not worth documenting in the README, it's a pretty ugly stop gap solution. We should not be loading complete files in memory, see #29898

@GavinZZ GavinZZ added the pr-linter/exempt-readme The PR linter will not require README changes label May 13, 2024
GavinZZ
GavinZZ previously approved these changes May 13, 2024
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aws-cdk-automation aws-cdk-automation dismissed their stale review May 13, 2024 23:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented May 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@nmussy
Copy link
Contributor Author

nmussy commented May 14, 2024

@Mergifyio refresh

Copy link
Contributor

mergify bot commented May 14, 2024

refresh

✅ Pull request refreshed

@nmussy
Copy link
Contributor Author

nmussy commented May 14, 2024

https://github.com/Mergifyio refresh

Copy link
Contributor

mergify bot commented May 14, 2024

refresh

✅ Pull request refreshed

@nmussy
Copy link
Contributor Author

nmussy commented May 14, 2024

@Mergifyio refresh

Copy link
Contributor

mergify bot commented May 14, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot dismissed GavinZZ’s stale review May 14, 2024 23:44

Pull request has been modified.

Copy link
Contributor

mergify bot commented May 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8ddc4ef
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4b6dc8c into aws:main May 15, 2024
9 checks passed
Copy link
Contributor

mergify bot commented May 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-service-catalog): SIGKILL: 9 CustomCDKBucketDeployment Lambda runs out of memory
3 participants