feat(ses-actions): WorkMail rule action
#29854
Conversation
github-actions
bot
added
p2
distinguished-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
There was a problem hiding this comment.
Any reason not to add the action to the existing integration test?
There was a problem hiding this comment.
This version wasn't merged yet, I'll merge them
There was a problem hiding this comment.
@nmussy Thanks! Can you please double-check why the unrelated integration test snapshot files were updated?
There was a problem hiding this comment.
Sorry, didn't notice the huge diff. I think I ran a build on @aws-cdk-testing/framework-integ that I shouldn't have? Anyway, should be good now
aws-cdk-automation
removed
the
pr/needs-community-review
aws-cdk-automation
added
the
pr/needs-maintainer-review
| */ | ||
|
|
||
| const TEST_EMAIL = '[email protected]'; | ||
| const TEST_WORKMAIL_DOMAIN = 'cdk-test-123.awsapps.com'; | ||
| const TEST_ORGANIZATION_ARN = 'arn:aws:workmail:us-east-1:339712719728:organization/m-5ea60ed9e37442c388898996f05c17ac'; |
There was a problem hiding this comment.
Curious whose account is 339712719728?
There was a problem hiding this comment.
Mine 😅 If a maintainer wants to update the snapshot with a CDK team account feel free to do so. I assumed it would be easier for everyone to let whoever updates this particular snapshot to update these constants
There was a problem hiding this comment.
I'm fine leaving it here since we will always test the snapshot if there's no change. But please make sure to remove the bucket yourself to avoid any potential issue.
| * 3. Update the TEST_EMAIL constant with the email address of the user you created | ||
| * 4. Deploy the stack with --no-clean, and send an email to the email address you created | ||
| * 5. Check the following: | ||
| * 3. Remove the automatically created INBOUND_MAIL rule set (https://us-east-1.console.aws.amazon.com/ses/home?region=us-east-1#/email-receiving/INBOUND_MAIL) |
There was a problem hiding this comment.
Can you explain why we need this step/change?
There was a problem hiding this comment.
The default INBOND_MAIL is created by WorkMail and already has a WorkMail rule. I was updating the rule before this PR, but we need to test that it's being created correctly now
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
None that I could find
Reason for this change
Adds missing
WorkMailSES rule actionDescription of changes
WorkMailactionDescription of how you validated changes
Added unit test, integ test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license