Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sns): add TracingConfig prop #29783

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Conversation

jun1-t
Copy link
Contributor

@jun1-t jun1-t commented Apr 10, 2024

Issue # (if applicable)

Closes #29714

Reason for this change

Currently, to set the TracingConfig, it is necessary to configure it via L1.
So, add TracingConfig props to L2.

Description of changes

added TracingConfig props to topic.ts, sns.test.ts, integ.sns.ts, and README.md for AWS SNS.

Description of how you validated changes

I confirmed with unit test and integ test that it works as expected.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Apr 10, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 10, 2024 15:05
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Apr 10, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review April 10, 2024 15:25

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

@nmussy nmussy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously reviewed in #29715, still LGTM 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 10, 2024
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Excellent feedback here from @nmussy so I have nothing further.

For future reference, maintainers can reopen closed PRs regardless of who closes them so feel free to tag one of us and we can help reopen the original one, if that's easier for you.

Copy link
Contributor

mergify bot commented Apr 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 11, 2024
Copy link
Contributor

mergify bot commented Apr 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jun1-t
Copy link
Contributor Author

jun1-t commented Apr 11, 2024

@TheRealAmazonKendra @nmussy
Thank you for the approval. And, thank you for letting me know about reopening the pull request. I understand.

However, it appears that the subsequent check failed. The details of the error that occurred during the check, it is written as follows, but I'm unsure what specific actions to take. What should I do?

Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@nmussy
Copy link
Contributor

nmussy commented Apr 11, 2024

You should have a checkbox on the right side of this page, which needs to be selected, "Allow edits and access to secrets by maintainers"

image

Once it's done, you can send the message @mergifyio update to force it to refresh and merge

@jun1-t
Copy link
Contributor Author

jun1-t commented Apr 11, 2024

@Mergifyio update

Copy link
Contributor

mergify bot commented Apr 11, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@nmussy
Copy link
Contributor

nmussy commented Apr 11, 2024

This might be an issue with mergify, I'll let a maintainer take over

@jun1-t
Copy link
Contributor Author

jun1-t commented Apr 11, 2024

@nmussy

This might be an issue with mergify, I'll let a maintainer take over

Thank you for letting me know. I understand.
It looks slightly different from nmussy's image, but the checkbox appears to be selected.
image

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review April 12, 2024 18:04

Pull request has been modified.

Copy link
Contributor

mergify bot commented Apr 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e4c12e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f14b60f into aws:main Apr 12, 2024
10 checks passed
Copy link
Contributor

mergify bot commented Apr 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@jun1-t
Copy link
Contributor Author

jun1-t commented Apr 13, 2024

@xazhao
Thank you for merging.

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sns: Support for TracingConfig
5 participants