Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs): L2 for ebs task attach #28691

Merged
merged 12 commits into from
Jan 17, 2024
Merged

feat(ecs): L2 for ebs task attach #28691

merged 12 commits into from
Jan 17, 2024

Conversation

KollaAdithya
Copy link
Contributor

@KollaAdithya KollaAdithya commented Jan 12, 2024 •
edited by MrArnoldPalmer
Loading

To simplify ECS customer experience, customers need the ability to utilize highly available (HA) durable, high-performance, cost effective block storage for their workloads. To address these needs, ECS will provide support for Elastic Block Storage (EBS) task attachments.

This PR adds the L2 constructs for EBS task attach.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jan 12, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 12, 2024 14:32
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 12, 2024
@MrArnoldPalmer MrArnoldPalmer added the pr/do-not-merge This PR should not be merged at this time. label Jan 12, 2024
@MrArnoldPalmer
Copy link
Contributor

@KollaAdithya is changing the fileSystemType prop to be an enum since these are known documented strings, inspired by #28682

@MrArnoldPalmer MrArnoldPalmer mentioned this pull request Jan 12, 2024
Closed
@MrArnoldPalmer
Copy link
Contributor

@go-to-k I put the wrong link in the last PR comment, sorry. Give this one a look.

go-to-k
go-to-k suggested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on a few things. If I find something else later, I may comment on it.

packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 12, 2024
@KollaAdithya @go-to-k
use enum for propagateTags
19d47fe 
add validations

Co-authored-by: go-to-k <[email protected]>
go-to-k
go-to-k suggested changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changing!

I've added a few more comments that I hope you'll take a look at.

packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/base-service.ts Outdated Show resolved Hide resolved
go-to-k
go-to-k suggested changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I only commented on minor points at the end. I will approve this when it is completed.

packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/base-service.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-ecs/lib/base/service-managed-volume.ts Outdated Show resolved Hide resolved
@KollaAdithya
Copy link
Contributor Author

KollaAdithya commented Jan 15, 2024 •
edited
Loading

@MrArnoldPalmer and @go-to-k All the feedback is addressed. Can you take a look and approve it

go-to-k
go-to-k approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @KollaAdithya .
I approve this.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 15, 2024
MrArnoldPalmer
MrArnoldPalmer previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 17, 2024
@mergify mergify bot dismissed MrArnoldPalmer’s stale review January 17, 2024 18:24

Pull request has been modified.

@MrArnoldPalmer MrArnoldPalmer removed the pr/do-not-merge This PR should not be merged at this time. label Jan 17, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fc0eabb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fc0a89a into aws:main Jan 17, 2024
14 checks passed
@KollaAdithya KollaAdithya deleted the ebs-task-attach-launch branch January 17, 2024 22:56
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
This was referenced Feb 10, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrArnoldPalmer MrArnoldPalmer MrArnoldPalmer approved these changes

@go-to-k go-to-k go-to-k approved these changes

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KollaAdithya @MrArnoldPalmer @aws-cdk-automation @go-to-k