-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(opensearchservice): OpenSearchAccessPolicy unnecessarily attempts to install latest sdk version #28688
fix(opensearchservice): OpenSearchAccessPolicy unnecessarily attempts to install latest sdk version #28688
Conversation
… to install latest sdk version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This introduced uncertainty into the resource behavior, adds at least 60s to the execution time and will cause deployments in CN regions to fail.
No tests add because the existing tests run with the
@aws-cdk/customresources:installLatestAwsSdkDefault
feature flag set to the recommended value. This change is merely change theOpenSearchAccessPolicy
config for users that don't set the feature flag. We can safely do this, because we control the code for this custom resource and know it works with the provided SDK version.Related to #27597
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license