-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec2): add dual stack vpc support #28480
Conversation
Update fork
|
||
/** | ||
* An abstract Provider of IpAddresses | ||
* | ||
* Note this is specific to the IPv4 CIDR. | ||
*/ | ||
export class IpAddresses { | ||
/** | ||
* Used to provide local Ip Address Management services for your VPC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: IP
- same applies in a few places below.
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adds parameter to configure a dual stack vpc, `vpcProtocol: ec2.VpcProtocol.DUAL_STACK`. By default a dual stack vpc will: - Create an Amazon provided IPv6 CIDR block (/56) and associate it to the VPC. - Assign a portion of the block to each of the subnets (/64) - Enable autoassigning an IPv6 address for each subnet - **Disable autoassigning public IPv4 addresses** for each subnet - Create an Egress Only Internet Gateway for private subnets - Configure IPv6 routes for IGWs and EIGWs Addresses #894. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@@ -1809,11 +1813,7 @@ export class Vpc extends VpcBase { | |||
privateSubnet.node.addDependency(this.ipv6CidrBlock); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldnt Isolated subnet also be added here to prevent a racecondition?
Adds parameter to configure a dual stack vpc,
ipProtocol: ec2.IpProtocol.DUAL_STACK
.By default a dual stack vpc will:
Addresses #894.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license