-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scheduler): typo in metricSentToDLQ... methods #28307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request: In addition to the absence of existing tests, I think there is no need to add tests for this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol whoops. Wouldn't it be funny if we changed the name to metricSentToDLQTrunc
instead :)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
@kaizencc
It failed at this part of the script.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR includes breaking changes to the
aws-scheduler-alpha
module.Description
This PR introduces breaking changes by correcting typos in the method names of the Schedule and Group constructs.
Specifically, the method name
metricSentToDLQTrunacted
has been changed tometricSentToDLQTruncated
, andmetricAllSentToDLQTrunacted
has been changed tometricAllSentToDLQTruncated
.https://docs.aws.amazon.com/scheduler/latest/UserGuide/monitoring-cloudwatch.html
BREAKING CHANGE: The typos in the Schedule and Group construct method names have been fixed, changing
metricSentToDLQTrunacted
tometricSentToDLQTruncated
andmetricAllSentToDLQTrunacted
tometricAllSentToDLQTruncated
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license