Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are noUnusedLocals and noUnusedParameters set to true by default? #2648

Closed
abelmokadem opened this issue May 27, 2019 · 3 comments
Closed

Comments

@abelmokadem
Copy link
Contributor

Why are these 2 fields set to true in tsconfig.json? Just wondering.

    "noUnusedLocals": true,
    "noUnusedParameters": true,

I keep changing them to false in all my projects because I prefer to assign any value I create to a variable so that I know what it is without having to look at the value itself. I know that this is a matter of taste, but I'm also wondering whether it's just me who is changing this in every project.

Cheers!

@rix0rrr
Copy link
Contributor

rix0rrr commented May 28, 2019

Assuming you are talking about the projects generated using cdk init, I think this request is justified. It is not great for usability.

@eladb
Copy link
Contributor

eladb commented May 28, 2019

+1 we'll accept a PR to change this

@abelmokadem
Copy link
Contributor Author

#2654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants