Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions-tasks): custom resource uses subprocess with Shell=true #22752

Merged
merged 4 commits into from
Nov 2, 2022

Conversation

otaviomacedo
Copy link
Contributor

Using Shell=true in subprocess functions is considered a security vulnerability. To avoid using this argument, the command has to be passed as an array rather than a string.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 2, 2022

@github-actions github-actions bot added the p2 label Nov 2, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team November 2, 2022 19:21
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 2, 2022
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@otaviomacedo otaviomacedo added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Nov 2, 2022
@otaviomacedo
Copy link
Contributor Author

There are no changes to integ tests, but I ran the relevant one and it passed. Its snapshot has been updated accordingly.

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 2, 2022 19:27

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2e17030
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit bd056d1 into main Nov 2, 2022
@mergify mergify bot deleted the otaviom/stepfunctions-no-shell branch November 2, 2022 20:37
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants