fix(region-info): EC2 service principal is incorrect in GovCloud regions #22589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kaizencc
commented
Oct 20, 2022
packages/@aws-cdk/region-info/test/__snapshots__/region-info.test.js.snap
Show resolved
Hide resolved
aws-cdk-automation
previously requested changes
Oct 20, 2022
|
I know the build has failed; I can work on fixing that when we confirm that this is what we want |
rix0rrr
requested changes
Oct 25, 2022
kaizencc
commented
Oct 25, 2022
packages/@aws-cdk/region-info/test/__snapshots__/region-info.test.js.snap
Show resolved
Hide resolved
kaizencc
added
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
kaizencc
changed the title
rix0rrr
approved these changes
Nov 1, 2022
rix0rrr
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to these docs, "The AWS service principal for Amazon EC2 is ec2.amazonaws.com, but the former service principal of ec2.c2s.ic.gov is still supported for backward compatibility."