Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cli): replace colors.js with chalk #18329

Closed
1 of 2 tasks
blimmer opened this issue Jan 9, 2022 · 4 comments
Closed
1 of 2 tasks

(cli): replace colors.js with chalk #18329

blimmer opened this issue Jan 9, 2022 · 4 comments
Assignees
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. package/tools Related to AWS CDK Tools or CLI

Comments

@blimmer
Copy link
Contributor

blimmer commented Jan 9, 2022

Description

A recent publish of colors.js is causing problems for a lot of software projects, including aws-cdk (see #18322, #18323, and #18324). The author of colors.js seems to be in crisis right now, and relying on their projects is risky.

Migrating from colors.js to chalk is probably a good idea to reduce risk for aws-cdk users.

Use Case

For folks who do not pin aws-cdk (e.g., those who install globally or use npx to run), they could accidentally get one of the broken versions of colors.js.

Proposed Solution

colors is replaced with chalk and remove from dependencies of aws-cdk/package.json

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@blimmer blimmer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 9, 2022
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Jan 9, 2022
@leantorres73
Copy link

I was expecting to find this issue already created. Thanks this is something really important

@fourhundredfour
Copy link

I completely agree that the change should be made, however, it is not as critical as it is portrayed here.

There is a yarn.lock file in which among other things the hash is locked as well as the version number.

Also a hotfix was published. See #18324

@jumic
Copy link
Contributor

jumic commented Jan 24, 2022

colors.js was replaced with chalk in #18363.
@peterwoodworth I think this issue can be closed. Thanks.

@blimmer blimmer closed this as completed Jan 24, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

5 participants