fix(ecr): Generate valid CloudFormation for imageScanOnPush #13420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when enabling scan on push
|
|
github-actions
bot
added
the
@aws-cdk/aws-cloudformation
github-actions
bot
added
the
@aws-cdk/aws-ecr
Contributor
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
cplee
changed the title
MrArnoldPalmer
approved these changes
Mar 5, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
cornerwings
pushed a commit
to cornerwings/aws-cdk
that referenced
this pull request
Mar 8, 2021
fix aws#13418: Update ECR construct to generate valid CloudFormation when enabling `imageScanOnPush` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #13418: Update ECR construct to generate valid CloudFormation when enabling
imageScanOnPushBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license