feat(amplify-domain): Added config for auto subdomain creation #13342
Conversation
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
MrArnoldPalmer
left a comment
MrArnoldPalmer
left a comment
There was a problem hiding this comment.
Some small changes. Additionally one of the tests fails to compile because, but I believe this will be fixed by making enabledAutoSubdomain optional.
|
|
mergify
bot
dismissed
MrArnoldPalmer’s stale review
Pull request has been modified.
janario
changed the title
janario
force-pushed
the
feature/enable-auto-subdomain-config
branch
from
9a4b40d to
4959332
Compare
janario
force-pushed
the
feature/enable-auto-subdomain-config
branch
from
4959332 to
19ac74d
Compare
janario
changed the title
|
@MrArnoldPalmer Review suggestion done, as well as lint, test, doc and build fixes. Please, give it another review ;-) |
| domainName, | ||
| subDomainSettings: Lazy.any({ produce: () => this.renderSubDomainSettings() }, { omitEmptyArray: true }), | ||
| enableAutoSubDomain: !!props.enableAutoSubdomain, | ||
| autoSubDomainCreationPatterns: props.autoSubdomainCreationPatterns || ['*', 'pr*'], |
There was a problem hiding this comment.
This makes it so that only when a user passes enableAutoSubdomain: true all branches will automatically get their own subdomains deployed right? if enableAutoSubDomain: false this default doesn't really matter right?
This is fine with me I'm just making sure.
There was a problem hiding this comment.
From the web interface that's the behavior, by enabling enableAutoSubDomain=true all branches listen. But when I tried from the CloudFormation without providing autoSubdomainCreationPatterns it didn't seem to get a default so I tried to keep a similar behaviour
and yes, when enableAutoSubDomain=false the autoSubdomainCreationPatterns is filled but ignored
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
3 participants
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license