feat(core): description parameter in the CustomResourceProvider
#13275
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
This was referenced Feb 25, 2021
robertd
force-pushed
the
custom-resource-description
branch
2 times, most recently
from
6698295 to
da405fa
Compare
robertd
changed the title
robertd
force-pushed
the
custom-resource-description
branch
from
da405fa to
802ca23
Compare
…ceProvider construct
robertd
force-pushed
the
custom-resource-description
branch
from
802ca23 to
275738c
Compare
robertd
changed the title
rix0rrr
changed the title
rix0rrr
changed the title
description parameter in the CustomResourceProvider
rix0rrr
approved these changes
Feb 25, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Feb 25, 2021
…meter for custom resources (#13276) Integration test in `core` module requires that any custom description parameter integration tests should be done in `cloudformation` module. https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/core/test/integration.custom-resources.readme ``` +--------------------------------------------------------------------------+ | Since cdk-integ depends on cdk which depends on @aws-cdk/core (as a "dev | | dependency"), this integration test has been added to the package | | @aws-cdk/aws-cloudformation under `test/integ.core-custom-resources.ts` | +--------------------------------------------------------------------------+ ``` Depends on #13275 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Feb 25, 2021
… for better recognition of the s3 auto-delete lambda functions in AWS console (#13277) When having a huge amount of lambda functions it's always nice to have a populated description for better determining the "prurpose-at-a-glance" of what this function is doing (in case you cannot deduce that information from lambda's name). Depends on #13275. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Mar 6, 2021
This was referenced Mar 8, 2021
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by #13277 and #13276
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license