feat(aws-events): Event Bus target #12926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alanraison
force-pushed
the
cross-account-event-bus
branch
from
0b22111 to
a598ba6
Compare
alanraison
changed the title
alanraison
force-pushed
the
cross-account-event-bus
branch
from
a598ba6 to
3890c03
Compare
alanraison
force-pushed
the
cross-account-event-bus
branch
from
3890c03 to
d3317f8
Compare
rix0rrr
changed the title
rix0rrr
previously approved these changes
Feb 9, 2021
rix0rrr
approved these changes
Feb 9, 2021
rix0rrr
previously requested changes
Feb 9, 2021
Contributor
rix0rrr
left a comment
rix0rrr
left a comment
There was a problem hiding this comment.
There are linter errors:
@aws-cdk/aws-events-targets: /codebuild/output/src935408083/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-events-targets/test/event-bus/event-rule-target.test.ts
@aws-cdk/aws-events-targets: 16:18 error Trailing spaces not allowed no-trailing-spaces
@aws-cdk/aws-events-targets: 17:54 error Missing trailing comma comma-dangle
@aws-cdk/aws-events-targets: 62:13 error Trailing spaces not allowed no-trailing-spaces
@aws-cdk/aws-events-targets: 63:18 error Trailing spaces not allowed no-trailing-spaces
@aws-cdk/aws-events-targets: 64:54 error Missing trailing comma comma-dangle
@aws-cdk/aws-events-targets: /codebuild/output/src935408083/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-events-targets/test/event-bus/integ.event-bus.ts
@aws-cdk/aws-events-targets: 19:72 error Missing trailing comma comma-dangle
Contributor
Author
|
Hi @rix0rrr I've updated the PR as requested (sorry about missing the linting), any chance of another review? Thanks! |
rix0rrr
previously approved these changes
Feb 26, 2021
mergify
bot
dismissed
rix0rrr’s stale review
Pull request has been modified.
rix0rrr
approved these changes
Feb 26, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Mar 8, 2021
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9473
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license