fix(servicecatalog): incorrect service in portfolio arn generation (#21770)

Portfolio construct code uses the incorrect service name when generating the ARN for the portfolio. The ARN generated uses the service name "servicecatalog" instead of "catalog". CLI documentation confirms ARN should use catalog instead of servicecatalog: https://docs.aws.amazon.com/cli/latest/reference/servicecatalog/create-portfolio.html

Added a single unit test to check arn formatting.

fixes #20849
----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: edyl-berkeley

packages/@aws-cdk/aws-servicecatalog/lib/portfolio.ts

@@ -329,7 +329,7 @@ export class Portfolio extends PortfolioBase {
     });
     this.portfolioId = this.portfolio.ref;
     this.portfolioArn = cdk.Stack.of(this).formatArn({
-      service: 'servicecatalog',
+      service: 'catalog',
       resource: 'portfolio',
       resourceName: this.portfolioId,
     });

packages/@aws-cdk/aws-servicecatalog/test/portfolio.test.ts

@@ -62,6 +62,14 @@ describe('Portfolio', () => {
       }).toThrowError(/Missing required Portfolio ID from Portfolio ARN/);
     }),
 
+    test('portfolio arn formatting', () => {
+      const portfolio = new servicecatalog.Portfolio(stack, 'Portfolio', {
+        displayName: 'MyPortfolio',
+        providerName: 'testProvider',
+      });
+      expect(portfolio.portfolioArn).toEqual(`arn:${stack.partition}:catalog:${stack.region}:${stack.account}:portfolio/${portfolio.portfolioId}`);
+    }),
+
     test('fails portfolio creation with short name', () => {
       expect(() => {
         new servicecatalog.Portfolio(stack, 'MyPortfolio', {