Skip to content

Commit d6cf535

Browse files
authored
Merge branch 'master' into cli-change-set-name
2 parents 39d3546 + e628a73 commit d6cf535

File tree

211 files changed

+5106
-2130
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

211 files changed

+5106
-2130
lines changed

.dependabot/config.yml

Lines changed: 0 additions & 19 deletions
This file was deleted.

.github/dependabot.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# Reference: https://docs.github.com/en/github/administering-a-repository/configuration-options-for-dependency-updates
2+
# NOTE: dependabot only takes care of updating non-npm deps
3+
# npm dependencies are updated through the "yarn-upgrade" github workflow.
4+
5+
version: 2
6+
updates:
7+
- package-ecosystem: "github-actions"
8+
directory: "/"
9+
schedule:
10+
interval: "weekly"
11+
labels:
12+
- "pr/auto-approve"
13+
open-pull-requests-limit: 5

.github/workflows/auto-approve-dependabot.yml

Lines changed: 0 additions & 27 deletions
This file was deleted.

.github/workflows/auto-approve.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# Approve PRs with "pr/auto-approve". mergify takes care of the actual merge.
2+
3+
name: auto-approve
4+
on: pull_request
5+
6+
jobs:
7+
auto-approve:
8+
if: >
9+
contains(github.event.pull_request.labels.*.name, 'pr/auto-approve') &&
10+
(github.event.pull_request.user.login == 'aws-cdk-automation'
11+
|| github.event.pull_request.user.login == 'dependabot[bot]'
12+
|| github.event.pull_request.user.login == 'dependabot-preview[bot]')
13+
runs-on: ubuntu-latest
14+
steps:
15+
- uses: hmarr/[email protected]
16+
with:
17+
github-token: "${{ secrets.GITHUB_TOKEN }}"

.github/workflows/v2-pull-request.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,3 @@ jobs:
3232
uses: stefanzweifel/git-auto-commit-action@v4
3333
with:
3434
commit_message: 'automatic pkglint fixes'
35-
36-
# Approve automated PRs
37-
# Only approve! mergify takes care of the actual merge.
38-
auto-approve:
39-
if: >
40-
github.event.pull_request.user.login == 'aws-cdk-automation'
41-
&& contains(github.event.pull_request.labels.*.name, 'pr/auto-approve')
42-
runs-on: ubuntu-latest
43-
steps:
44-
- uses: hmarr/[email protected]
45-
with:
46-
github-token: "${{ secrets.GITHUB_TOKEN }}"

.github/workflows/yarn-upgrade.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
run: echo "::set-output name=dir::$(yarn cache dir)"
2626

2727
- name: Restore Yarn cache
28-
uses: actions/cache@v2
28+
uses: actions/cache@v2.1.4
2929
with:
3030
path: ${{ steps.yarn-cache.outputs.dir }}
3131
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
@@ -74,7 +74,7 @@ jobs:
7474
title: 'chore: npm-check-updates && yarn upgrade'
7575
body: |-
7676
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
77-
labels: contribution/core,dependencies
77+
labels: contribution/core,dependencies,pr/auto-approve
7878
team-reviewers: aws-cdk-team
7979
# Privileged token so automated PR validation happens
8080
token: ${{ secrets.AUTOMATION_GITHUB_TOKEN }}

packages/@aws-cdk-containers/ecs-service-extensions/test/integ.assign-public-ip.expected.json

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,9 @@
400400
"Type": "AWS::SQS::Queue",
401401
"Properties": {
402402
"MessageRetentionPeriod": 1209600
403-
}
403+
},
404+
"UpdateReplacePolicy": "Delete",
405+
"DeletionPolicy": "Delete"
404406
},
405407
"nameserviceTaskRecordManagerEventsQueueF805A6C1": {
406408
"Type": "AWS::SQS::Queue",
@@ -415,7 +417,9 @@
415417
"maxReceiveCount": 500
416418
},
417419
"VisibilityTimeout": 30
418-
}
420+
},
421+
"UpdateReplacePolicy": "Delete",
422+
"DeletionPolicy": "Delete"
419423
},
420424
"nameserviceTaskRecordManagerEventsQueuePolicy65CC6F9E": {
421425
"Type": "AWS::SQS::QueuePolicy",
@@ -746,14 +750,12 @@
746750
]
747751
}
748752
},
749-
"Handler": "index.queue_handler",
750753
"Role": {
751754
"Fn::GetAtt": [
752755
"nameserviceTaskRecordManagerEventHandlerServiceRoleE66EE52A",
753756
"Arn"
754757
]
755758
},
756-
"Runtime": "python3.8",
757759
"Environment": {
758760
"Variables": {
759761
"HOSTED_ZONE_ID": {
@@ -777,7 +779,9 @@
777779
}
778780
}
779781
},
782+
"Handler": "index.queue_handler",
780783
"ReservedConcurrentExecutions": 1,
784+
"Runtime": "python3.8",
781785
"Timeout": 30
782786
},
783787
"DependsOn": [
@@ -788,14 +792,14 @@
788792
"nameserviceTaskRecordManagerEventHandlerSqsEventSourceawsecsintegnameserviceTaskRecordManagerEventsQueueC5EE9A869F1EB155": {
789793
"Type": "AWS::Lambda::EventSourceMapping",
790794
"Properties": {
795+
"FunctionName": {
796+
"Ref": "nameserviceTaskRecordManagerEventHandler4B8C6905"
797+
},
791798
"EventSourceArn": {
792799
"Fn::GetAtt": [
793800
"nameserviceTaskRecordManagerEventsQueueF805A6C1",
794801
"Arn"
795802
]
796-
},
797-
"FunctionName": {
798-
"Ref": "nameserviceTaskRecordManagerEventHandler4B8C6905"
799803
}
800804
}
801805
},
@@ -909,13 +913,13 @@
909913
]
910914
}
911915
},
912-
"Handler": "index.cleanup_resource_handler",
913916
"Role": {
914917
"Fn::GetAtt": [
915918
"nameserviceTaskRecordManagerCleanupResourceProviderHandlerServiceRoleCCA462F0",
916919
"Arn"
917920
]
918921
},
922+
"Handler": "index.cleanup_resource_handler",
919923
"Runtime": "python3.8",
920924
"Timeout": 300
921925
},
@@ -1022,14 +1026,12 @@
10221026
]
10231027
}
10241028
},
1025-
"Handler": "framework.onEvent",
10261029
"Role": {
10271030
"Fn::GetAtt": [
10281031
"nameserviceTaskRecordManagerCleanupResourceProviderframeworkonEventServiceRoleF0570BD0",
10291032
"Arn"
10301033
]
10311034
},
1032-
"Runtime": "nodejs10.x",
10331035
"Description": "AWS CDK resource provider framework - onEvent (aws-ecs-integ/name-service/TaskRecordManager/CleanupResourceProvider)",
10341036
"Environment": {
10351037
"Variables": {
@@ -1041,6 +1043,8 @@
10411043
}
10421044
}
10431045
},
1046+
"Handler": "framework.onEvent",
1047+
"Runtime": "nodejs10.x",
10441048
"Timeout": 900
10451049
},
10461050
"DependsOn": [
@@ -1242,13 +1246,13 @@
12421246
]
12431247
}
12441248
},
1245-
"Handler": "index.handler",
12461249
"Role": {
12471250
"Fn::GetAtt": [
12481251
"AWS679f53fac002430cb0da5b7982bd2287ServiceRoleC1EA0FF2",
12491252
"Arn"
12501253
]
12511254
},
1255+
"Handler": "index.handler",
12521256
"Runtime": "nodejs12.x",
12531257
"Timeout": 120
12541258
},

packages/@aws-cdk-containers/ecs-service-extensions/test/integ.imported-environment.expected.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@
4949
]
5050
]
5151
}
52-
}
52+
},
53+
"UpdateReplacePolicy": "Delete",
54+
"DeletionPolicy": "Delete"
5355
},
5456
"ServiceloadbalancerD5D60894": {
5557
"Type": "AWS::ElasticLoadBalancingV2::LoadBalancer",

packages/@aws-cdk/aws-apigateway/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ The following example shows how to use an API Key with a usage plan:
163163

164164
```ts
165165
const hello = new lambda.Function(this, 'hello', {
166-
runtime: lambda.Runtime.NODEJS_10_X,
166+
runtime: lambda.Runtime.NODEJS_12_X,
167167
handler: 'hello.handler',
168168
code: lambda.Code.fromAsset('lambda')
169169
});
@@ -230,7 +230,7 @@ The following example shows how to use a rate limited api key :
230230

231231
```ts
232232
const hello = new lambda.Function(this, 'hello', {
233-
runtime: lambda.Runtime.NODEJS_10_X,
233+
runtime: lambda.Runtime.NODEJS_12_X,
234234
handler: 'hello.handler',
235235
code: lambda.Code.fromAsset('lambda')
236236
});
@@ -260,7 +260,7 @@ have to define your models and mappings for the request, response, and integrati
260260

261261
```ts
262262
const hello = new lambda.Function(this, 'hello', {
263-
runtime: lambda.Runtime.NODEJS_10_X,
263+
runtime: lambda.Runtime.NODEJS_12_X,
264264
handler: 'hello.handler',
265265
code: lambda.Code.fromAsset('lambda')
266266
});

packages/@aws-cdk/aws-apigateway/test/authorizers/integ.cognito-authorizer.expected.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@
2727
"EmailSubject": "Verify your new account",
2828
"SmsMessage": "The verification code to your new account is {####}"
2929
}
30-
}
30+
},
31+
"UpdateReplacePolicy": "Retain",
32+
"DeletionPolicy": "Retain"
3133
},
3234
"myauthorizer23CB99DD": {
3335
"Type": "AWS::ApiGateway::Authorizer",

0 commit comments

Comments
 (0)