Skip to content

Commit b04ea36

Browse files
authored
Merge branch 'master' into master
2 parents a80a1a1 + b1c0437 commit b04ea36

File tree

13 files changed

+152
-84
lines changed

13 files changed

+152
-84
lines changed

packages/@aws-cdk/aws-eks/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -466,6 +466,8 @@ const cluster = new eks.Cluster(this, 'hello-eks', {
466466
});
467467
```
468468

469+
The default value is `eks.EndpointAccess.PUBLIC_AND_PRIVATE`. Which means the cluster endpoint is accessible from outside of your VPC, but worker node traffic and `kubectl` commands issued by this library stay within your VPC.
470+
469471
### VPC Support
470472

471473
You can specify the VPC of the cluster using the `vpc` and `vpcSubnets` properties:
@@ -634,8 +636,6 @@ $ aws eks update-kubeconfig --name cluster-xxxxx --role-arn arn:aws:iam::1122334
634636
Added new context arn:aws:eks:rrrrr:112233445566:cluster/cluster-xxxxx to /home/boom/.kube/config
635637
```
636638

637-
The default value is `eks.EndpointAccess.PUBLIC_AND_PRIVATE`. Which means the cluster endpoint is accessible from outside of your VPC, but worker node traffic and `kubectl` commands issued by this library stay within your VPC.
638-
639639
### Encryption
640640

641641
When you create an Amazon EKS cluster, envelope encryption of Kubernetes secrets using the AWS Key Management Service (AWS KMS) can be enabled.

packages/@aws-cdk/aws-eks/lib/kubectl-provider.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ export class KubectlProvider extends NestedStack {
106106
onEventHandler: handler,
107107
vpc: cluster.kubectlPrivateSubnets ? cluster.vpc : undefined,
108108
vpcSubnets: cluster.kubectlPrivateSubnets ? { subnets: cluster.kubectlPrivateSubnets } : undefined,
109+
securityGroups: cluster.kubectlSecurityGroup ? [cluster.kubectlSecurityGroup] : undefined,
109110
});
110111

111112
this.serviceToken = provider.serviceToken;

packages/@aws-cdk/aws-eks/test/integ.eks-cluster-handlers-vpc.expected.json

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1194,7 +1194,7 @@
11941194
},
11951195
"/",
11961196
{
1197-
"Ref": "AssetParameters3a065cef8968eb7f7e62ccb379c68400a56c31aceb97265d4e8f5f4620452db9S3Bucket7930790A"
1197+
"Ref": "AssetParameters93bb4c1c6bbced2c1adce602d7643d5475c6e463f4f57f4cd863e064d82a3d82S3Bucket8670C328"
11981198
},
11991199
"/",
12001200
{
@@ -1204,7 +1204,7 @@
12041204
"Fn::Split": [
12051205
"||",
12061206
{
1207-
"Ref": "AssetParameters3a065cef8968eb7f7e62ccb379c68400a56c31aceb97265d4e8f5f4620452db9S3VersionKey648E56F4"
1207+
"Ref": "AssetParameters93bb4c1c6bbced2c1adce602d7643d5475c6e463f4f57f4cd863e064d82a3d82S3VersionKeyCEFB3AF5"
12081208
}
12091209
]
12101210
}
@@ -1217,7 +1217,7 @@
12171217
"Fn::Split": [
12181218
"||",
12191219
{
1220-
"Ref": "AssetParameters3a065cef8968eb7f7e62ccb379c68400a56c31aceb97265d4e8f5f4620452db9S3VersionKey648E56F4"
1220+
"Ref": "AssetParameters93bb4c1c6bbced2c1adce602d7643d5475c6e463f4f57f4cd863e064d82a3d82S3VersionKeyCEFB3AF5"
12211221
}
12221222
]
12231223
}
@@ -1272,9 +1272,6 @@
12721272
"referencetoawscdkekshandlersinvpctestAssetParameters844c1a4b13479b359ea0e607dccb4a04b73e22cf88cf9b64feed2c5f0de213c0S3VersionKeyCE91E7FDRef": {
12731273
"Ref": "AssetParameters844c1a4b13479b359ea0e607dccb4a04b73e22cf88cf9b64feed2c5f0de213c0S3VersionKeyF55A2EA9"
12741274
},
1275-
"referencetoawscdkekshandlersinvpctestEksAllHandlersInVpcStackDefaultVpcE40EA7ACRef": {
1276-
"Ref": "EksAllHandlersInVpcStackDefaultVpcBE11D4AE"
1277-
},
12781275
"referencetoawscdkekshandlersinvpctestAssetParametersdaeb79e3cee39c9b902dc0d5c780223e227ed573ea60976252947adab5fb2be1S3Bucket9D7E9998Ref": {
12791276
"Ref": "AssetParametersdaeb79e3cee39c9b902dc0d5c780223e227ed573ea60976252947adab5fb2be1S3BucketDC4B98B1"
12801277
},
@@ -1400,17 +1397,17 @@
14001397
"Type": "String",
14011398
"Description": "Artifact hash for asset \"70396475d85a52e5c6ccad77894979d07433a207ea3c2668b929f3e70ffde081\""
14021399
},
1403-
"AssetParameters3a065cef8968eb7f7e62ccb379c68400a56c31aceb97265d4e8f5f4620452db9S3Bucket7930790A": {
1400+
"AssetParameters93bb4c1c6bbced2c1adce602d7643d5475c6e463f4f57f4cd863e064d82a3d82S3Bucket8670C328": {
14041401
"Type": "String",
1405-
"Description": "S3 bucket for asset \"3a065cef8968eb7f7e62ccb379c68400a56c31aceb97265d4e8f5f4620452db9\""
1402+
"Description": "S3 bucket for asset \"93bb4c1c6bbced2c1adce602d7643d5475c6e463f4f57f4cd863e064d82a3d82\""
14061403
},
1407-
"AssetParameters3a065cef8968eb7f7e62ccb379c68400a56c31aceb97265d4e8f5f4620452db9S3VersionKey648E56F4": {
1404+
"AssetParameters93bb4c1c6bbced2c1adce602d7643d5475c6e463f4f57f4cd863e064d82a3d82S3VersionKeyCEFB3AF5": {
14081405
"Type": "String",
1409-
"Description": "S3 key for asset version \"3a065cef8968eb7f7e62ccb379c68400a56c31aceb97265d4e8f5f4620452db9\""
1406+
"Description": "S3 key for asset version \"93bb4c1c6bbced2c1adce602d7643d5475c6e463f4f57f4cd863e064d82a3d82\""
14101407
},
1411-
"AssetParameters3a065cef8968eb7f7e62ccb379c68400a56c31aceb97265d4e8f5f4620452db9ArtifactHash66195F00": {
1408+
"AssetParameters93bb4c1c6bbced2c1adce602d7643d5475c6e463f4f57f4cd863e064d82a3d82ArtifactHashBEC324DA": {
14121409
"Type": "String",
1413-
"Description": "Artifact hash for asset \"3a065cef8968eb7f7e62ccb379c68400a56c31aceb97265d4e8f5f4620452db9\""
1410+
"Description": "Artifact hash for asset \"93bb4c1c6bbced2c1adce602d7643d5475c6e463f4f57f4cd863e064d82a3d82\""
14141411
}
14151412
}
14161413
}

packages/@aws-cdk/aws-eks/test/integ.eks-cluster-private-endpoint.expected.json

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1115,7 +1115,7 @@
11151115
},
11161116
"/",
11171117
{
1118-
"Ref": "AssetParameterseb49ce353c5ff251ebe2c3225fe00fb3e9a68fcd8b10207e63a36bfc6e981519S3Bucket686DCA97"
1118+
"Ref": "AssetParameters8d4ffe9194a1ca97e2e9377049ddbeb3adbdaa984c8a90c08a5d8d6b328bdf7cS3BucketFEA5F85E"
11191119
},
11201120
"/",
11211121
{
@@ -1125,7 +1125,7 @@
11251125
"Fn::Split": [
11261126
"||",
11271127
{
1128-
"Ref": "AssetParameterseb49ce353c5ff251ebe2c3225fe00fb3e9a68fcd8b10207e63a36bfc6e981519S3VersionKey7EDC0140"
1128+
"Ref": "AssetParameters8d4ffe9194a1ca97e2e9377049ddbeb3adbdaa984c8a90c08a5d8d6b328bdf7cS3VersionKey226CF52C"
11291129
}
11301130
]
11311131
}
@@ -1138,7 +1138,7 @@
11381138
"Fn::Split": [
11391139
"||",
11401140
{
1141-
"Ref": "AssetParameterseb49ce353c5ff251ebe2c3225fe00fb3e9a68fcd8b10207e63a36bfc6e981519S3VersionKey7EDC0140"
1141+
"Ref": "AssetParameters8d4ffe9194a1ca97e2e9377049ddbeb3adbdaa984c8a90c08a5d8d6b328bdf7cS3VersionKey226CF52C"
11421142
}
11431143
]
11441144
}
@@ -1193,9 +1193,6 @@
11931193
"referencetoawscdkeksclusterprivateendpointtestAssetParameters844c1a4b13479b359ea0e607dccb4a04b73e22cf88cf9b64feed2c5f0de213c0S3VersionKey548D79B4Ref": {
11941194
"Ref": "AssetParameters844c1a4b13479b359ea0e607dccb4a04b73e22cf88cf9b64feed2c5f0de213c0S3VersionKeyF55A2EA9"
11951195
},
1196-
"referencetoawscdkeksclusterprivateendpointtestVpcFCD064BFRef": {
1197-
"Ref": "Vpc8378EB38"
1198-
},
11991196
"referencetoawscdkeksclusterprivateendpointtestAssetParametersdaeb79e3cee39c9b902dc0d5c780223e227ed573ea60976252947adab5fb2be1S3Bucket7DDAFC04Ref": {
12001197
"Ref": "AssetParametersdaeb79e3cee39c9b902dc0d5c780223e227ed573ea60976252947adab5fb2be1S3BucketDC4B98B1"
12011198
},
@@ -1321,17 +1318,17 @@
13211318
"Type": "String",
13221319
"Description": "Artifact hash for asset \"75667ab2bbef2c8efc57fb73bf352f345af1d471fb09cb11f5b7bc27d009b609\""
13231320
},
1324-
"AssetParameterseb49ce353c5ff251ebe2c3225fe00fb3e9a68fcd8b10207e63a36bfc6e981519S3Bucket686DCA97": {
1321+
"AssetParameters8d4ffe9194a1ca97e2e9377049ddbeb3adbdaa984c8a90c08a5d8d6b328bdf7cS3BucketFEA5F85E": {
13251322
"Type": "String",
1326-
"Description": "S3 bucket for asset \"eb49ce353c5ff251ebe2c3225fe00fb3e9a68fcd8b10207e63a36bfc6e981519\""
1323+
"Description": "S3 bucket for asset \"8d4ffe9194a1ca97e2e9377049ddbeb3adbdaa984c8a90c08a5d8d6b328bdf7c\""
13271324
},
1328-
"AssetParameterseb49ce353c5ff251ebe2c3225fe00fb3e9a68fcd8b10207e63a36bfc6e981519S3VersionKey7EDC0140": {
1325+
"AssetParameters8d4ffe9194a1ca97e2e9377049ddbeb3adbdaa984c8a90c08a5d8d6b328bdf7cS3VersionKey226CF52C": {
13291326
"Type": "String",
1330-
"Description": "S3 key for asset version \"eb49ce353c5ff251ebe2c3225fe00fb3e9a68fcd8b10207e63a36bfc6e981519\""
1327+
"Description": "S3 key for asset version \"8d4ffe9194a1ca97e2e9377049ddbeb3adbdaa984c8a90c08a5d8d6b328bdf7c\""
13311328
},
1332-
"AssetParameterseb49ce353c5ff251ebe2c3225fe00fb3e9a68fcd8b10207e63a36bfc6e981519ArtifactHashE5817DEB": {
1329+
"AssetParameters8d4ffe9194a1ca97e2e9377049ddbeb3adbdaa984c8a90c08a5d8d6b328bdf7cArtifactHashA6BF0EB3": {
13331330
"Type": "String",
1334-
"Description": "Artifact hash for asset \"eb49ce353c5ff251ebe2c3225fe00fb3e9a68fcd8b10207e63a36bfc6e981519\""
1331+
"Description": "Artifact hash for asset \"8d4ffe9194a1ca97e2e9377049ddbeb3adbdaa984c8a90c08a5d8d6b328bdf7c\""
13351332
}
13361333
}
13371334
}

packages/@aws-cdk/aws-eks/test/integ.eks-cluster.expected.json

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3877,7 +3877,7 @@
38773877
},
38783878
"/",
38793879
{
3880-
"Ref": "AssetParameters9f954a0baf5cb008231906c33569617ace43f4b2c804d16d0d4bae15fe9dfabcS3BucketF9C7C3C5"
3880+
"Ref": "AssetParameterse00474136b86298d67c0ad626f1dafe622c51168233097531c5ba6791d43aba3S3Bucket5829AD66"
38813881
},
38823882
"/",
38833883
{
@@ -3887,7 +3887,7 @@
38873887
"Fn::Split": [
38883888
"||",
38893889
{
3890-
"Ref": "AssetParameters9f954a0baf5cb008231906c33569617ace43f4b2c804d16d0d4bae15fe9dfabcS3VersionKey950894D5"
3890+
"Ref": "AssetParameterse00474136b86298d67c0ad626f1dafe622c51168233097531c5ba6791d43aba3S3VersionKey44FDB4A8"
38913891
}
38923892
]
38933893
}
@@ -3900,7 +3900,7 @@
39003900
"Fn::Split": [
39013901
"||",
39023902
{
3903-
"Ref": "AssetParameters9f954a0baf5cb008231906c33569617ace43f4b2c804d16d0d4bae15fe9dfabcS3VersionKey950894D5"
3903+
"Ref": "AssetParameterse00474136b86298d67c0ad626f1dafe622c51168233097531c5ba6791d43aba3S3VersionKey44FDB4A8"
39043904
}
39053905
]
39063906
}
@@ -3955,9 +3955,6 @@
39553955
"referencetoawscdkeksclustertestAssetParameters844c1a4b13479b359ea0e607dccb4a04b73e22cf88cf9b64feed2c5f0de213c0S3VersionKey1CADE360Ref": {
39563956
"Ref": "AssetParameters844c1a4b13479b359ea0e607dccb4a04b73e22cf88cf9b64feed2c5f0de213c0S3VersionKeyF55A2EA9"
39573957
},
3958-
"referencetoawscdkeksclustertestVpc9A302ADDRef": {
3959-
"Ref": "Vpc8378EB38"
3960-
},
39613958
"referencetoawscdkeksclustertestAssetParametersdaeb79e3cee39c9b902dc0d5c780223e227ed573ea60976252947adab5fb2be1S3Bucket0815E7B5Ref": {
39623959
"Ref": "AssetParametersdaeb79e3cee39c9b902dc0d5c780223e227ed573ea60976252947adab5fb2be1S3BucketDC4B98B1"
39633960
},
@@ -4709,17 +4706,17 @@
47094706
"Type": "String",
47104707
"Description": "Artifact hash for asset \"264acf17cbf0c643f47bec1f4dbaed805e3bd1bad3f018c093d16fb936227daa\""
47114708
},
4712-
"AssetParameters9f954a0baf5cb008231906c33569617ace43f4b2c804d16d0d4bae15fe9dfabcS3BucketF9C7C3C5": {
4709+
"AssetParameterse00474136b86298d67c0ad626f1dafe622c51168233097531c5ba6791d43aba3S3Bucket5829AD66": {
47134710
"Type": "String",
4714-
"Description": "S3 bucket for asset \"9f954a0baf5cb008231906c33569617ace43f4b2c804d16d0d4bae15fe9dfabc\""
4711+
"Description": "S3 bucket for asset \"e00474136b86298d67c0ad626f1dafe622c51168233097531c5ba6791d43aba3\""
47154712
},
4716-
"AssetParameters9f954a0baf5cb008231906c33569617ace43f4b2c804d16d0d4bae15fe9dfabcS3VersionKey950894D5": {
4713+
"AssetParameterse00474136b86298d67c0ad626f1dafe622c51168233097531c5ba6791d43aba3S3VersionKey44FDB4A8": {
47174714
"Type": "String",
4718-
"Description": "S3 key for asset version \"9f954a0baf5cb008231906c33569617ace43f4b2c804d16d0d4bae15fe9dfabc\""
4715+
"Description": "S3 key for asset version \"e00474136b86298d67c0ad626f1dafe622c51168233097531c5ba6791d43aba3\""
47194716
},
4720-
"AssetParameters9f954a0baf5cb008231906c33569617ace43f4b2c804d16d0d4bae15fe9dfabcArtifactHash5984E3CE": {
4717+
"AssetParameterse00474136b86298d67c0ad626f1dafe622c51168233097531c5ba6791d43aba3ArtifactHashB6A3908A": {
47214718
"Type": "String",
4722-
"Description": "Artifact hash for asset \"9f954a0baf5cb008231906c33569617ace43f4b2c804d16d0d4bae15fe9dfabc\""
4719+
"Description": "Artifact hash for asset \"e00474136b86298d67c0ad626f1dafe622c51168233097531c5ba6791d43aba3\""
47234720
},
47244721
"SsmParameterValueawsserviceeksoptimizedami119amazonlinux2recommendedimageidC96584B6F00A464EAD1953AFF4B05118Parameter": {
47254722
"Type": "AWS::SSM::Parameter::Value<String>",
@@ -4738,4 +4735,4 @@
47384735
"Default": "/aws/service/eks/optimized-ami/1.19/amazon-linux-2-gpu/recommended/image_id"
47394736
}
47404737
}
4741-
}
4738+
}

packages/@aws-cdk/aws-eks/test/integ.fargate-cluster.expected.json

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1192,7 +1192,7 @@
11921192
},
11931193
"/",
11941194
{
1195-
"Ref": "AssetParameters37d93b8a35af568f83ecce5e05c6f06adaa06c68b84dfad9c3d82f57cd54ff13S3BucketDCD73A4E"
1195+
"Ref": "AssetParametersedcd50bb250cf7cf664a737720e623ad66ada9b9e609205686c476e516cf2f23S3Bucket586F6135"
11961196
},
11971197
"/",
11981198
{
@@ -1202,7 +1202,7 @@
12021202
"Fn::Split": [
12031203
"||",
12041204
{
1205-
"Ref": "AssetParameters37d93b8a35af568f83ecce5e05c6f06adaa06c68b84dfad9c3d82f57cd54ff13S3VersionKey796F5C1B"
1205+
"Ref": "AssetParametersedcd50bb250cf7cf664a737720e623ad66ada9b9e609205686c476e516cf2f23S3VersionKey6EFBFC1D"
12061206
}
12071207
]
12081208
}
@@ -1215,7 +1215,7 @@
12151215
"Fn::Split": [
12161216
"||",
12171217
{
1218-
"Ref": "AssetParameters37d93b8a35af568f83ecce5e05c6f06adaa06c68b84dfad9c3d82f57cd54ff13S3VersionKey796F5C1B"
1218+
"Ref": "AssetParametersedcd50bb250cf7cf664a737720e623ad66ada9b9e609205686c476e516cf2f23S3VersionKey6EFBFC1D"
12191219
}
12201220
]
12211221
}
@@ -1270,9 +1270,6 @@
12701270
"referencetoawscdkeksfargateclustertestAssetParameters844c1a4b13479b359ea0e607dccb4a04b73e22cf88cf9b64feed2c5f0de213c0S3VersionKeyFE6D1F78Ref": {
12711271
"Ref": "AssetParameters844c1a4b13479b359ea0e607dccb4a04b73e22cf88cf9b64feed2c5f0de213c0S3VersionKeyF55A2EA9"
12721272
},
1273-
"referencetoawscdkeksfargateclustertestFargateClusterDefaultVpcBD3C976FRef": {
1274-
"Ref": "FargateClusterDefaultVpcE69D3A13"
1275-
},
12761273
"referencetoawscdkeksfargateclustertestAssetParametersdaeb79e3cee39c9b902dc0d5c780223e227ed573ea60976252947adab5fb2be1S3Bucket8EEF0922Ref": {
12771274
"Ref": "AssetParametersdaeb79e3cee39c9b902dc0d5c780223e227ed573ea60976252947adab5fb2be1S3BucketDC4B98B1"
12781275
},
@@ -1398,17 +1395,17 @@
13981395
"Type": "String",
13991396
"Description": "Artifact hash for asset \"3d252d05ccf0ae2934dd20707e8a709b466b2b8ea00c04ee8735667f90b17ac1\""
14001397
},
1401-
"AssetParameters37d93b8a35af568f83ecce5e05c6f06adaa06c68b84dfad9c3d82f57cd54ff13S3BucketDCD73A4E": {
1398+
"AssetParametersedcd50bb250cf7cf664a737720e623ad66ada9b9e609205686c476e516cf2f23S3Bucket586F6135": {
14021399
"Type": "String",
1403-
"Description": "S3 bucket for asset \"37d93b8a35af568f83ecce5e05c6f06adaa06c68b84dfad9c3d82f57cd54ff13\""
1400+
"Description": "S3 bucket for asset \"edcd50bb250cf7cf664a737720e623ad66ada9b9e609205686c476e516cf2f23\""
14041401
},
1405-
"AssetParameters37d93b8a35af568f83ecce5e05c6f06adaa06c68b84dfad9c3d82f57cd54ff13S3VersionKey796F5C1B": {
1402+
"AssetParametersedcd50bb250cf7cf664a737720e623ad66ada9b9e609205686c476e516cf2f23S3VersionKey6EFBFC1D": {
14061403
"Type": "String",
1407-
"Description": "S3 key for asset version \"37d93b8a35af568f83ecce5e05c6f06adaa06c68b84dfad9c3d82f57cd54ff13\""
1404+
"Description": "S3 key for asset version \"edcd50bb250cf7cf664a737720e623ad66ada9b9e609205686c476e516cf2f23\""
14081405
},
1409-
"AssetParameters37d93b8a35af568f83ecce5e05c6f06adaa06c68b84dfad9c3d82f57cd54ff13ArtifactHash8F2277C1": {
1406+
"AssetParametersedcd50bb250cf7cf664a737720e623ad66ada9b9e609205686c476e516cf2f23ArtifactHashB34EB8FE": {
14101407
"Type": "String",
1411-
"Description": "Artifact hash for asset \"37d93b8a35af568f83ecce5e05c6f06adaa06c68b84dfad9c3d82f57cd54ff13\""
1408+
"Description": "Artifact hash for asset \"edcd50bb250cf7cf664a737720e623ad66ada9b9e609205686c476e516cf2f23\""
14121409
}
14131410
}
14141411
}

packages/@aws-cdk/aws-eks/test/test.cluster.ts

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2083,6 +2083,27 @@ export = {
20832083

20842084
},
20852085

2086+
'kubectl provider passes security group to provider'(test: Test) {
2087+
2088+
const { stack } = testFixture();
2089+
2090+
new eks.Cluster(stack, 'Cluster1', {
2091+
version: CLUSTER_VERSION,
2092+
prune: false,
2093+
endpointAccess: eks.EndpointAccess.PRIVATE,
2094+
kubectlEnvironment: {
2095+
Foo: 'Bar',
2096+
},
2097+
});
2098+
2099+
// the kubectl provider is inside a nested stack.
2100+
const nested = stack.node.tryFindChild('@aws-cdk/aws-eks.KubectlProvider') as cdk.NestedStack;
2101+
test.deepEqual(expect(nested).value.Resources.ProviderframeworkonEvent83C1D0A7.Properties.VpcConfig.SecurityGroupIds,
2102+
[{ Ref: 'referencetoStackCluster18DFEAC17ClusterSecurityGroupId' }]);
2103+
2104+
test.done();
2105+
},
2106+
20862107
'kubectl provider passes environment to lambda'(test: Test) {
20872108

20882109
const { stack } = testFixture();

packages/@aws-cdk/aws-lambda-nodejs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
"cdk-build-tools": "0.0.0",
6868
"cdk-integ-tools": "0.0.0",
6969
"delay": "5.0.0",
70-
"esbuild": "^0.8.49",
70+
"esbuild": "^0.8.50",
7171
"pkglint": "0.0.0"
7272
},
7373
"dependencies": {

packages/@aws-cdk/aws-s3-deployment/README.md

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -156,39 +156,15 @@ import * as origins from '@aws-cdk/aws-cloudfront-origins';
156156

157157
const bucket = new s3.Bucket(this, 'Destination');
158158

159-
// Option 1 (Stable): Handles buckets whether or not they are configured for website hosting.
159+
// Handles buckets whether or not they are configured for website hosting.
160160
const distribution = new cloudfront.Distribution(this, 'Distribution', {
161161
defaultBehavior: { origin: new origins.S3Origin(bucket) },
162162
});
163163

164-
// Option 2 (Stable): Use this if the bucket has website hosting enabled.
165-
const distribution_for_website_bucket = new cloudfront.CloudFrontWebDistribution(this, 'DistributionForWebBucket', {
166-
originConfigs: [
167-
{
168-
customOriginSource: {
169-
domainName: bucket.bucketWebsiteDomainName,
170-
},
171-
behaviors : [ {isDefaultBehavior: true}]
172-
}
173-
]
174-
});
175-
176-
// Option 3 (Stable): Use this version if the bucket does not have website hosting enabled.
177-
const distribution_for_bucket = new cloudfront.CloudFrontWebDistribution(this, 'DistributionForBucket', {
178-
originConfigs: [
179-
{
180-
s3OriginSource: {
181-
s3BucketSource: bucket
182-
},
183-
behaviors : [ {isDefaultBehavior: true}]
184-
}
185-
]
186-
});
187-
188164
new s3deploy.BucketDeployment(this, 'DeployWithInvalidation', {
189165
sources: [s3deploy.Source.asset('./website-dist')],
190166
destinationBucket: bucket,
191-
distribution, // or distribution_for_website_bucket or distribution_for_bucket
167+
distribution,
192168
distributionPaths: ['/images/*.png'],
193169
});
194170
```

packages/@aws-cdk/aws-s3/lib/bucket.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1161,8 +1161,8 @@ export interface BucketProps {
11611161
*
11621162
* @see https://docs.aws.amazon.com/AmazonS3/latest/dev/access-control-block-public-access.html
11631163
*
1164-
* @default false New buckets and objects don't allow public access, but users can modify bucket
1165-
* policies or object permissions to allow public access.
1164+
*
1165+
* @default - CloudFormation defaults will apply. New buckets and objects don't allow public access, but users can modify bucket policies or object permissions to allow public access
11661166
*/
11671167
readonly blockPublicAccess?: BlockPublicAccess;
11681168

0 commit comments

Comments
 (0)